Add support for float16 matmul#42
Open
LaurentMazare wants to merge 1 commit intoblas-lapack-rs:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in #41 it would be nice to have support for half precision matmul (especially when using mkl).
This PR adds it and goes together with blas-lapack-rs/blas-sys#21 on the sys side. The blas-sys version has been bumped to reflect the new requirement.
Let me know if there is anything that could be done to improve this PR or the blas-sys one, or if you see any different way to get this working.
Thanks,
Note that this has been tested in a very simple way via the following: