Skip to content

Add onClear event#10

Open
BesatZardosht wants to merge 4 commits intoblackjk3:masterfrom
BesatZardosht:master
Open

Add onClear event#10
BesatZardosht wants to merge 4 commits intoblackjk3:masterfrom
BesatZardosht:master

Conversation

@BesatZardosht
Copy link
Copy Markdown

It is nice to have onClear event callback

Copy link
Copy Markdown
Contributor

@sospedra sospedra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙅‍♂️

Comment thread package.json Outdated
{
"name": "react-signature-pad",
"version": "0.0.5",
"name": "react-signature-pad-component",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ This PR hijacks the npm name, version and authority ⚠️

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry! I didn't know I shouldn't change version and name. I send a merge request. So you can add onClear event in the original module

@Stenerson
Copy link
Copy Markdown

Can this be rebuilt and merged? It would be helpful use this callback, specifically for checking/resetting a parent's isEmpty state after a clear.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants