use ActionView::Helpers::DateHelper for crack_time_display#42
Open
finchi wants to merge 2 commits intobitzesty:masterfrom
Open
use ActionView::Helpers::DateHelper for crack_time_display#42finchi wants to merge 2 commits intobitzesty:masterfrom
finchi wants to merge 2 commits intobitzesty:masterfrom
Conversation
Contributor
|
@finchi This is a problem of the wrapped js library in one of the dependencies. |
Weddin
approved these changes
Mar 20, 2025
aaanosov
approved these changes
Mar 20, 2025
aaanosov
approved these changes
Mar 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since
crack_time_displaygets passed as a I18n variable, it would be nice if it would be already translated withdistance_of_time_in_words. Else it doesn't make sense to use it with other languages