PM-37985: Feat: Use PolicyView in the app

[david-livefront]

🎟️ Tracking

PM-37985

📔 Objective

This PR updates the PolicyManager to use PolicyView as the primary policy model. All downstream users of PolicyManager have been updated as well.

[codecov]

Codecov Report

❌ Patch coverage is 95.55556% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.07%. Comparing base (b53d3fb) to head (982e42d).

Files with missing lines	Patch %	Lines
...n/ui/tools/feature/generator/GeneratorViewModel.kt	0.00%	2 Missing ⚠️
...twarden/data/platform/manager/PolicyManagerImpl.kt	90.90%	0 Missing and 1 partial ⚠️
...a/platform/manager/util/PolicyManagerExtensions.kt	87.50%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6966      +/-   ##
==========================================
- Coverage   86.21%   86.07%   -0.14%     
==========================================
  Files        1007      917      -90     
  Lines       66068    65366     -702     
  Branches     9267     9244      -23     
==========================================
- Hits        56962    56267     -695     
- Misses       5912     5928      +16     
+ Partials     3194     3171      -23     

Flag	Coverage Δ
app-data	16.78% <65.55%> (-0.48%)	⬇️
app-ui-auth-tools	19.06% <7.95%> (-0.34%)	⬇️
app-ui-platform	16.81% <12.50%> (-0.24%)	⬇️
app-ui-vault	28.42% <19.31%> (-0.02%)	⬇️
authenticator	6.25% <0.00%> (+0.02%)	⬆️
lib-core-network-bridge	4.10% <0.00%> (+<0.01%)	⬆️
lib-data-ui	1.15% <0.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions]

Bitwarden Claude Code Review

Overall Assessment: APPROVE

This PR is a mechanical refactor that migrates PolicyManager and 25+ call sites from SyncResponseJson.Policy/PolicyTypeJson to the SDK's PolicyView/PolicyType. The new VaultSdkPolicyExtensions utility converts network policies into SDK views with exhaustive coverage of all 22 PolicyTypeJson values, and JSON data is serialized to a string for the SDK shape. The four type renames (ONLY_ORG→SINGLE_ORG, PERSONAL_OWNERSHIP→ORGANIZATION_DATA_OWNERSHIP, FREE_FAMILIES_SPONSORSHIP_POLICY→FREE_FAMILIES_SPONSORSHIP, RESTRICT_ITEM_TYPES→RESTRICTED_ITEM_TYPES) are deliberate alignments to SDK naming. Tests are updated comprehensively, with a dedicated VaultSdkPolicyExtensionsTest covering conversion, JSON-string serialization, and the full type-mapping table.

Code Review Details

No actionable findings. The refactor is correctly typed, the policy-type mapping is exhaustive, the read-side policyInformation extension correctly switches from JsonObject.toString() to direct String? decoding, mock factories (createMockPolicyView / createMockPolicy) share aligned default values, and patch coverage is 95.55%.

[SaintPatrck]

❓ Just want to sanity check; this is the SDK equivalent of PERSONAL_OWNERSHIP?

[david-livefront]

Yep, the SDK looks like this:

    ORGANIZATION_DATA_OWNERSHIP(5u),

And ours looks like this:

    @SerialName("5")
    PERSONAL_OWNERSHIP,

[david-livefront]

Thanks @SaintPatrck