Skip to content

Add more information on touch devices in settings - #884

Draft
stonko1994 wants to merge 5 commits into
developfrom
feature/add-more-option-settings-panel
Draft

Add more information on touch devices in settings#884
stonko1994 wants to merge 5 commits into
developfrom
feature/add-more-option-settings-panel

Conversation

@stonko1994

@stonko1994 stonko1994 commented May 22, 2026

Copy link
Copy Markdown
Collaborator

Description

Adds a More page to mobile settings panels so touch users can access Bitmovin Player and UI version information without relying on the desktop context menu.

Screenshot 2026-05-22 at 10 33 05

Checklist (for PR submitter and reviewers)

  • CHANGELOG entry

@stonko1994 stonko1994 changed the title Expose player information in mobile settings Add player information on touch devices in 'more' option in settings May 22, 2026
@stonko1994
stonko1994 requested a review from Copilot May 22, 2026 08:33
@stonko1994 stonko1994 changed the title Add player information on touch devices in 'more' option in settings Add more information on touch devices in settings May 22, 2026
@stonko1994
stonko1994 force-pushed the feature/add-more-option-settings-panel branch from b57d5a7 to b4f3557 Compare May 22, 2026 08:39

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a “More” page to the mobile settings panel so touch/mobile users can access Bitmovin Player and UI version information without relying on the desktop context menu.

Changes:

  • Adds new settings components for page navigation, separators, and a player info page, and wires them into the default mobile settings panel.
  • Simplifies spatial-navigation focus handling in settings pages by treating all InteractiveSettingsPanelItems uniformly.
  • Adds the new settings.more i18n key across supported languages and includes new SCSS styling + changelog entry.

Reviewed changes

Copilot reviewed 18 out of 18 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/ts/UIFactory.ts Adds “More” entry + separator to mobile settings and registers the new info page.
src/ts/spatialnavigation/SettingsPanelNavigationGroup.ts Updates focusable-resolution logic to use InteractiveSettingsPanelItem.
src/ts/main.ts Exports newly added settings components/pages.
src/ts/localization/languages/en.json Adds settings.more translation.
src/ts/localization/languages/de.json Adds settings.more translation.
src/ts/localization/languages/es.json Adds settings.more translation.
src/ts/localization/languages/fr.json Adds settings.more translation.
src/ts/localization/languages/nl.json Adds settings.more translation.
src/ts/localization/languages/pt.json Adds settings.more translation.
src/ts/localization/i18n.ts Extends Vocabulary with settings.more.
src/ts/components/settings/SettingsPanelSeparator.ts Introduces a visual separator component for settings rows.
src/ts/components/settings/SettingsPanelPageNavigationItem.ts Adds a clickable settings-row component that navigates to another settings page.
src/ts/components/settings/PlayerInfoSettingsPanelPage.ts Adds the “More” destination page showing player/UI version info.
src/scss/components/settings/_settings-panel-separator.scss Styles the new separator row.
src/scss/components/settings/_settings-panel-page-navigation-item.scss Styles the new navigation row (trailing chevron).
src/scss/components/settings/_player-info-settings-panel-page.scss Styles the new player info page layout.
src/scss/bitmovinplayer-ui.scss Includes the new SCSS partials in the main stylesheet.
CHANGELOG.md Documents the new “More” page on mobile settings panels.
Comments suppressed due to low confidence (1)

src/ts/spatialnavigation/SettingsPanelNavigationGroup.ts:63

  • This change alters how focusable components are resolved (treating all InteractiveSettingsPanelItems as single focus targets). There are Jest specs for SettingsPanel/spatial navigation, but none covering this SettingsPanelNavigationGroup.getComponents() behavior; adding a unit test would help prevent regressions for keyboard/remote navigation across different item types.
  override getComponents(): Focusable[] {
    const activeSettingsPanelPage = this.settingsPanel.getActivePage();
    const pageComponents = activeSettingsPanelPage.getItems();

    const componentsToConsider: Focusable[] = [];
    pageComponents.forEach(component => {
      if (component instanceof InteractiveSettingsPanelItem) {
        componentsToConsider.push(component);
      } else {
        componentsToConsider.push(...resolveAllComponents(component));
      }

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

/**
* The label component or the text for the label.
*/
label: LocalizableText;
Comment on lines +61 to +66
constructor() {
const playerVersionLabel = new Label<LabelConfig>({
text: 'Player: -',
cssClasses: ['ui-player-info-settings-panel-page-info'],
});

@stonko1994
stonko1994 changed the base branch from feature/add-context-menu to feature/player-insights-panel June 8, 2026 11:01
@stonko1994
stonko1994 force-pushed the feature/add-more-option-settings-panel branch from b4f3557 to f59e8c9 Compare June 12, 2026 08:15
Base automatically changed from feature/player-insights-panel to feature/add-stats-for-nerds June 16, 2026 08:40
Base automatically changed from feature/add-stats-for-nerds to develop June 16, 2026 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants