Generate sitemaps XML#108
Draft
nuno-agostinho wants to merge 1 commit intomainfrom
Draft
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| from django.urls import reverse | ||
| from . import models | ||
|
|
||
| class AtlasSitemap(Sitemap): |
Contributor
There was a problem hiding this comment.
[Super-Linter] reported by reviewdog 🐶
Suggested change
| class AtlasSitemap(Sitemap): | |
| class AtlasSitemap(Sitemap): |
|
|
||
| class AtlasSitemap(Sitemap): | ||
| """Sitemap for Cell Atlas pages.""" | ||
| changefreq = "weekly" |
Contributor
There was a problem hiding this comment.
[Super-Linter] reported by reviewdog 🐶
Suggested change
| changefreq = "weekly" | |
| changefreq = "weekly" |
|
|
||
| def location(self, obj): | ||
| """Return the URL for the main page of a species.""" | ||
| return reverse('atlas_info', args=[obj.slug]) |
Contributor
There was a problem hiding this comment.
[Super-Linter] reported by reviewdog 🐶
Suggested change
| return reverse('atlas_info', args=[obj.slug]) | |
| return reverse("atlas_info", args=[obj.slug]) |
|
|
||
| class StaticViewSitemap(Sitemap): | ||
| """Sitemap for static pages.""" | ||
| changefreq = "monthly" |
Contributor
There was a problem hiding this comment.
[Super-Linter] reported by reviewdog 🐶
Suggested change
| changefreq = "monthly" | |
| changefreq = "monthly" |
| priority = 0.5 | ||
|
|
||
| def items(self): | ||
| return ['atlas', 'downloads', 'about', 'entry', 'reference', 'api'] |
Contributor
There was a problem hiding this comment.
[Super-Linter] reported by reviewdog 🐶
Suggested change
| return ['atlas', 'downloads', 'about', 'entry', 'reference', 'api'] | |
| return ["atlas", "downloads", "about", "entry", "reference", "api"] |
| return ['atlas', 'downloads', 'about', 'entry', 'reference', 'api'] | ||
|
|
||
| def location(self, item): | ||
| return reverse(item) No newline at end of file |
Contributor
There was a problem hiding this comment.
[Super-Linter] reported by reviewdog 🐶
Suggested change
| return reverse(item) | |
| return reverse(item) | |
Comment on lines
+13
to
+14
| 'static': StaticViewSitemap, | ||
| 'dataset': AtlasSitemap, |
Contributor
There was a problem hiding this comment.
[Super-Linter] reported by reviewdog 🐶
Suggested change
| 'static': StaticViewSitemap, | |
| 'dataset': AtlasSitemap, | |
| "static": StaticViewSitemap, | |
| "dataset": AtlasSitemap, |
Comment on lines
+129
to
+130
| path('sitemap.xml', sitemap, {'sitemaps': sitemaps}, name='sitemap'), | ||
|
|
Contributor
There was a problem hiding this comment.
[Super-Linter] reported by reviewdog 🐶
Suggested change
| path('sitemap.xml', sitemap, {'sitemaps': sitemaps}, name='sitemap'), | |
| path("sitemap.xml", sitemap, {"sitemaps": sitemaps}, name="sitemap"), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Google already crawls the website pretty well. What is the point of having a quite manual way to do this? Not as dynamic as I would have hoped for: new Cell Atlas and Database Entry sections need to be included manually (unless we find a non-built-in way to automate it).
Also,
/api/crawling is now discouraged by robots.txt.