Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the project’s CI and linting setup by removing legacy flake8/pep8 dependencies/config and introducing ruff, along with some formatting-only reflows to satisfy stricter lint rules.
Changes:
- Switch CI linting from flake8 to ruff and add ruff configuration in
pyproject.toml. - Remove flake8/pep8 from packaging and conda environment dependencies.
- Reformat a number of source/test lines (line wrapping) and add
.DS_Storeto.gitignore.
Reviewed changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| setup.py | Drops flake8/pep8 from install_requires (but still includes nose). |
| setup.cfg | Removes the old [flake8] configuration block. |
| pyproject.toml | Adds initial ruff lint rule selection. |
| environment.yml | Replaces flake8/pep8 with ruff in the conda environment. |
| .github/workflows/main.yaml | Updates CI python matrix and switches lint step to ruff check. |
| .gitignore | Ignores macOS .DS_Store. |
| pysyndna/src/quant_orfs.py | Formatting-only line wrap. |
| pysyndna/src/calc_cell_counts.py | Formatting-only line wraps. |
| pysyndna/tests/test_util.py | Formatting-only line wrap. |
| pysyndna/tests/test_quant_orfs.py | Formatting-only line wraps (comprehensions/DF construction). |
| pysyndna/tests/test_fit_syndna_models.py | Formatting-only line wraps; introduces a couple readability issues in comments/continuations. |
| pysyndna/tests/test_calc_cell_counts.py | Formatting-only line wraps; adds # noqa: E501 for long test names. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.