downgrade to DeprecationWarning, make lint fixes#12
Merged
AmandaBirmingham merged 1 commit intomainfrom Feb 27, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request updates deprecation warnings to be Python version-agnostic and applies lint fixes for flake8 W503 warnings. The changes replace the @deprecated decorator (which requires Python 3.13+) with the traditional warnings.warn() approach that works across all Python versions, and reformats multi-line expressions to follow PEP 8's updated style guide preference for line breaks before binary operators.
Changes:
- Replace
@deprecateddecorator withwarnings.warn(..., DeprecationWarning, stacklevel=2)for backward compatibility - Add flake8 configuration to ignore W503 (line break before binary operator)
- Reformat multi-line expressions to place binary operators at the start of continuation lines
- Fix various whitespace and indentation issues throughout the codebase
Reviewed changes
Copilot reviewed 5 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| setup.cfg | Added flake8 configuration to extend-ignore W503 warnings |
| pysyndna/src/calc_cell_counts.py | Replaced @deprecated decorator with warnings.warn() calls for 4 deprecated functions; reformatted multi-line expressions; fixed whitespace issues |
| pysyndna/src/util.py | Fixed operator spacing in division expression |
| pysyndna/src/fit_syndna_models.py | Reformatted multi-line expressions and function signatures; removed extra whitespace |
| pysyndna/tests/test_util.py | Reformatted import statement and fixed indentation in function calls |
| pysyndna/tests/test_quant_orfs.py | Fixed dictionary indentation |
| pysyndna/tests/test_fit_syndna_models.py | Removed extra whitespace in import statement |
| pysyndna/tests/test_calc_cell_counts.py | Fixed indentation in dictionary comprehensions and multi-line expressions; removed trailing whitespace |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.