Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request refactors the cell count calculation functions to consolidate sample and prep information into a single dataframe parameter, while maintaining backward compatibility through deprecated "split_input" versions. The refactoring simplifies the API by accepting a single prep_info_df parameter that contains all necessary columns (both sample and prep information) instead of requiring separate sample_info_df and prep_info_df parameters.
Changes:
- Added new versions of cell count calculation functions that accept a single combined dataframe parameter
- Deprecated the old "split_input" versions that accept separate sample_info and prep_info dataframes
- Added comprehensive test coverage for both the new unified interface and the deprecated split interface
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| pysyndna/src/calc_cell_counts.py | Refactored cell count functions to use unified dataframe input; added deprecation decorators to split_input versions; created new public API functions without split_input suffix |
| pysyndna/tests/test_calc_cell_counts.py | Added tests for new unified functions; updated test names and imports; added helper method for creating combined sample+prep test data |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.