Skip to content

Add sequenced_sample_gdna_mass_ng and sample extract metric columns to AbsQuantMixinV2 and pacbio notebook#367

Merged
AmandaBirmingham merged 2 commits intobiocore:masterfrom
AmandaBirmingham:sequenced_gdna_mass_in_samplesheet_20260320
Mar 30, 2026
Merged

Add sequenced_sample_gdna_mass_ng and sample extract metric columns to AbsQuantMixinV2 and pacbio notebook#367
AmandaBirmingham merged 2 commits intobiocore:masterfrom
AmandaBirmingham:sequenced_gdna_mass_in_samplesheet_20260320

Conversation

@AmandaBirmingham
Copy link
Copy Markdown
Collaborator

No description provided.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the PacBio AbsQuant v12 schema and notebook-based builder to include additional extract/input metric columns, and updates associated tests/fixtures to reflect the new output format.

Changes:

  • Extend AbsQuantMixinV2 (PacBio absquant v12) to require sequenced_sample_gdna_mass_ng plus the three sample-extract metric columns (calc_mass_sample_aliquot_input_g, sample_volume_ul, sample_surface_area_cm2).
  • Update the PacBio sample sheet builder notebook and its notebook tests to support selecting the active sample extract metric column.
  • Update expected output SampleSheet CSVs and processing-doc fixtures to include the new columns.

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
metapool/sample_sheet.py Adds new required AbsQuant v12 columns via AbsQuantMixinV2.
metapool/mp_strings.py Defines new column-key constants used across the codebase.
metapool/tests/test_sample_sheet.py Updates v12 absquant test inputs/expected outputs for new columns.
metapool/tests/data/good_pacbio_absquantv12.csv Updates v12 “good” fixture to include new columns.
notebooks/pacbio_sample_sheet_builder.ipynb Adds support for sample_extract_metric and emits new columns in notebook output.
notebooks/tests/test_pacbio_sample_sheet_builder.py Passes sample_extract_metric into notebook execution for absquant cases.
notebooks/test_output/SampleSheets/*.csv Updates expected notebook outputs with new headers/columns.
notebooks/test_data/processing_docs/*.csv Updates notebook input fixtures to supply the new metric fields.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Collaborator

@antgonza antgonza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sent one question via Slack but the changes look good to me.

@AmandaBirmingham AmandaBirmingham merged commit 87991af into biocore:master Mar 30, 2026
2 checks passed
@AmandaBirmingham AmandaBirmingham deleted the sequenced_gdna_mass_in_samplesheet_20260320 branch March 30, 2026 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants