Add sequenced_sample_gdna_mass_ng and sample extract metric columns to AbsQuantMixinV2 and pacbio notebook#367
Merged
AmandaBirmingham merged 2 commits intobiocore:masterfrom Mar 30, 2026
Conversation
…o AbsQuantMixinV2 and pacbio notebook
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the PacBio AbsQuant v12 schema and notebook-based builder to include additional extract/input metric columns, and updates associated tests/fixtures to reflect the new output format.
Changes:
- Extend
AbsQuantMixinV2(PacBio absquant v12) to requiresequenced_sample_gdna_mass_ngplus the three sample-extract metric columns (calc_mass_sample_aliquot_input_g,sample_volume_ul,sample_surface_area_cm2). - Update the PacBio sample sheet builder notebook and its notebook tests to support selecting the active sample extract metric column.
- Update expected output SampleSheet CSVs and processing-doc fixtures to include the new columns.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
metapool/sample_sheet.py |
Adds new required AbsQuant v12 columns via AbsQuantMixinV2. |
metapool/mp_strings.py |
Defines new column-key constants used across the codebase. |
metapool/tests/test_sample_sheet.py |
Updates v12 absquant test inputs/expected outputs for new columns. |
metapool/tests/data/good_pacbio_absquantv12.csv |
Updates v12 “good” fixture to include new columns. |
notebooks/pacbio_sample_sheet_builder.ipynb |
Adds support for sample_extract_metric and emits new columns in notebook output. |
notebooks/tests/test_pacbio_sample_sheet_builder.py |
Passes sample_extract_metric into notebook execution for absquant cases. |
notebooks/test_output/SampleSheets/*.csv |
Updates expected notebook outputs with new headers/columns. |
notebooks/test_data/processing_docs/*.csv |
Updates notebook input fixtures to supply the new metric fields. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
antgonza
approved these changes
Mar 23, 2026
Collaborator
antgonza
left a comment
There was a problem hiding this comment.
Sent one question via Slack but the changes look good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.