Skip to content

Add Hebrew#108

Draft
omeritzics wants to merge 9 commits into
bikram-agarwal:mainfrom
omeritzics:Hebrew-for-ObtainX
Draft

Add Hebrew#108
omeritzics wants to merge 9 commits into
bikram-agarwal:mainfrom
omeritzics:Hebrew-for-ObtainX

Conversation

@omeritzics

Copy link
Copy Markdown

Hi there!
I'm the maintainer of Updatium, another fork of Obtainium, which I opened in December 2025, mainly to add Hebrew support.
I can see many similarities between ObtainX and Updatium, and am open for future co-operation for improving our sister-projects.
The added translation file attached here is the Hebrew translation file of Updatium, after replacing Updatium's refs with ObtainX ones and running a script to make sure to include all the exclusive strings of ObtainX, and to exclude the exclusive strings to Updatium. Therefore, the Hebrew translation should work correctly if RTL support is set right on ObtainX (Obtainium's base code handles RTL seamlessly).

Hope this PR would help ObtainX, and I'm looking forward to see how our projects will grow :)

@bikram-agarwal

Copy link
Copy Markdown
Owner

Glad to hear from a fellow fork author! Thanks for the translation. I found a few issues that should be fixed before merge:

  • .flutter was added as a gitlink/subproject entry. That looks accidental and unrelated, so it should be removed from the PR.
  • Several Hebrew plural strings use named placeholders like {count} and {app}, but ObtainX currently calls these with positional args through plural(...). Those tokens will show literally in the UI. Examples include apps, apk, and xAndNMoreUpdates*. These should use the same positional {} placeholder shape as en.json.
  • A lot of user-facing strings are still English in he.json, such as onDemandOnlyDescription, editAppInfo, showFolderedAppsOnMainPageTooltip, and githubBuildVerificationTooltip. If this is intended as a complete Hebrew locale, those should be translated before shipping.

The JSON itself parses cleanly and the top-level key set matches en.json, so this looks fixable within the translation file plus removing the stray .flutter entry.

@omeritzics
omeritzics force-pushed the Hebrew-for-ObtainX branch from 784bfce to e94f62f Compare June 21, 2026 19:59
@omeritzics

Copy link
Copy Markdown
Author

Thank you for your feedback :)
I have indeed accidentally pushed along also changes from my projects. Now I've reverted them and force-pushed the translations alone.
About the translations, I'm on it, but it would take me some time, since some English terms could be a bit tricky to translate into Hebrew

Updated Hebrew locale file with translations for repository move checks,
insecure connection warnings, category filtering hints, and unsaved edits
confirmation dialog to improve user experience in Hebrew interface.
…data

Updated Hebrew locale with translations for:
- Theme and palette settings strings
- Accent color options
- App badges and version comparison labels
- Material You feature descriptions

Improves localization coverage for Hebrew interface users.

@bikram-agarwal bikram-agarwal left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't sure whether it is ready for review again, since I saw 2 new commits. I checked and see

  • assets/translations/he.json:737 changes ruleMatchesXApps from the source key’s named {count} placeholder to positional {}. The call site uses tr('ruleMatchesXApps', namedArgs: {'count': '$matchCount'}), so the Hebrew helper text will show literal {} instead of the match count.

  • The locale is still substantially partial English. Representative user-facing examples: downloadAPKToIdentifyAppExplanation at :46, batteryOptimizationWarningBody at :390, versionRegexAssistRawHint at :586, showFolderedAppsOnMainPageTooltip at :735, and githubBuildVerificationTooltip at :750. If this PR is intended to add a complete Hebrew locale, it is not there yet.

Please tag me when it is ready for review again.

@omeritzics

Copy link
Copy Markdown
Author

Unfortunately, no, my PR is not ready yet.

As Updatium is over 95% translated into Hebrew, I assumed that it would only require minor changes to adapt the Hebrew translation file for ObtainX. However, until your first comment, I wasn't aware that not only strings of ObtainX-exclusive features needed to be translated, but also many core functionality strings that didn't survive the transition due to different string IDs.

My deadline for releasing Updatium v26.6 is getting closer from day to day, so I'll now have to focus on releasing it and will only be able to continue working on the translations for ObtainX after then. I'll convert this PR into draft for now, and hope to continue working on the translations after the deadline pressure eases.

Thank you for your patience :)

@omeritzics
omeritzics marked this pull request as draft June 24, 2026 07:28
@bikram-agarwal
bikram-agarwal force-pushed the main branch 3 times, most recently from 688704e to 4f5a975 Compare July 10, 2026 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants