Add Hebrew#108
Conversation
|
Glad to hear from a fellow fork author! Thanks for the translation. I found a few issues that should be fixed before merge:
The JSON itself parses cleanly and the top-level key set matches |
784bfce to
e94f62f
Compare
|
Thank you for your feedback :) |
Updated Hebrew locale file with translations for repository move checks, insecure connection warnings, category filtering hints, and unsaved edits confirmation dialog to improve user experience in Hebrew interface.
…data Updated Hebrew locale with translations for: - Theme and palette settings strings - Accent color options - App badges and version comparison labels - Material You feature descriptions Improves localization coverage for Hebrew interface users.
bikram-agarwal
left a comment
There was a problem hiding this comment.
I wasn't sure whether it is ready for review again, since I saw 2 new commits. I checked and see
-
assets/translations/he.json:737changesruleMatchesXAppsfrom the source key’s named {count} placeholder to positional {}. The call site usestr('ruleMatchesXApps', namedArgs: {'count': '$matchCount'}), so the Hebrew helper text will show literal {} instead of the match count. -
The locale is still substantially partial English. Representative user-facing examples:
downloadAPKToIdentifyAppExplanationat :46,batteryOptimizationWarningBodyat :390,versionRegexAssistRawHintat :586,showFolderedAppsOnMainPageTooltipat :735, andgithubBuildVerificationTooltipat :750. If this PR is intended to add a complete Hebrew locale, it is not there yet.
Please tag me when it is ready for review again.
|
Unfortunately, no, my PR is not ready yet. As Updatium is over 95% translated into Hebrew, I assumed that it would only require minor changes to adapt the Hebrew translation file for ObtainX. However, until your first comment, I wasn't aware that not only strings of ObtainX-exclusive features needed to be translated, but also many core functionality strings that didn't survive the transition due to different string IDs. My deadline for releasing Updatium v26.6 is getting closer from day to day, so I'll now have to focus on releasing it and will only be able to continue working on the translations for ObtainX after then. I'll convert this PR into draft for now, and hope to continue working on the translations after the deadline pressure eases. Thank you for your patience :) |
688704e to
4f5a975
Compare
Hi there!
I'm the maintainer of Updatium, another fork of Obtainium, which I opened in December 2025, mainly to add Hebrew support.
I can see many similarities between ObtainX and Updatium, and am open for future co-operation for improving our sister-projects.
The added translation file attached here is the Hebrew translation file of Updatium, after replacing Updatium's refs with ObtainX ones and running a script to make sure to include all the exclusive strings of ObtainX, and to exclude the exclusive strings to Updatium. Therefore, the Hebrew translation should work correctly if RTL support is set right on ObtainX (Obtainium's base code handles RTL seamlessly).
Hope this PR would help ObtainX, and I'm looking forward to see how our projects will grow :)