fix: Preserve src-layout in source distributions#201
Open
gshiba wants to merge 2 commits intobihealth:mainfrom
Open
fix: Preserve src-layout in source distributions#201gshiba wants to merge 2 commits intobihealth:mainfrom
gshiba wants to merge 2 commits intobihealth:mainfrom
Conversation
The sdist build was flattening src/vcfpy/ to vcfpy/ but keeping the pyproject.toml reference to 'src/vcfpy', causing wheel builds from the tarball to create empty 3KB wheels instead of proper 43KB wheels. This broke: - Conda/bioconda builds - pip install --no-binary :all: - Any downstream packager building from source Fix: Use only-include=["src"] to preserve directory structure in sdist, ensuring builds from tarball work correctly. Tested: - Build from repo: 43KB wheel with 10 .py files ✓ - Build from tarball: 43KB wheel with 10 .py files ✓ Fixes bioconda-recipes build failures.
gshiba
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sdist build was flattening src/vcfpy/ to vcfpy/ but keeping the pyproject.toml reference to 'src/vcfpy', causing wheel builds from the tarball to create empty 3KB wheels instead of proper 43KB wheels.
This broke:
Fix: Use only-include=["src"] to preserve directory structure in sdist, ensuring builds from tarball work correctly.