Skip to content

deps: bump node 20.11.1 → 26.4.0 (take 2)#6855

Open
jaskfla wants to merge 1 commit into
devfrom
revert-6851-revert-6836-bump-node
Open

deps: bump node 20.11.1 → 26.4.0 (take 2)#6855
jaskfla wants to merge 1 commit into
devfrom
revert-6851-revert-6836-bump-node

Conversation

@jaskfla

@jaskfla jaskfla commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Reverts #6851 (which was itself a revert)

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 8b7813b. Configure here.

}

main |&
sudo -Hu ubuntu bash -leE -c "$(declare -f main); main" |&

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Startup failures skip errored tag

High Severity

Deployment startup now runs main inside a nested sudo/bash subshell piped to logging, while tag_errored and its ERR trap remain on the outer user-data shell. Failures during git, build, or deploy no longer run the trap, so instances can stay tagged StartupBuildProgress=building without errored or nginx stopped.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 8b7813b. Configure here.

DEPLOYMENT_NAME="$deployment_name" "$deployment_scripts"/connectTailscale.sh
# Build each package, including injecting environment variables from Bitwarden
sudo -Hu ubuntu "$deployment_scripts"/buildDeployablePackages.sh "$deployment_name"
"$deployment_scripts"/buildDeployablePackages.sh "$deployment_name"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preaggregation cron before Node switch

Medium Severity

Production startup still registers the preaggregation crontab before buildDeployablePackages.sh runs nvm install --default for Node 26.4.0, and the job no longer sources nvm explicitly. The cron line embeds whatever PATH was active earlier, often the AMI’s older Node or no nvm paths in non-interactive login shells.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 8b7813b. Configure here.

@jaskfla jaskfla force-pushed the revert-6851-revert-6836-bump-node branch 2 times, most recently from be2456f to ad575a8 Compare July 2, 2026 21:41
@jaskfla jaskfla force-pushed the revert-6851-revert-6836-bump-node branch from 88f9414 to 6568260 Compare July 2, 2026 22:34
@jaskfla jaskfla force-pushed the revert-6851-revert-6836-bump-node branch from 6568260 to 615d55f Compare July 3, 2026 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant