deps: bump node 20.11.1 → 26.4.0 (take 2)#6855
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 8b7813b. Configure here.
| } | ||
|
|
||
| main |& | ||
| sudo -Hu ubuntu bash -leE -c "$(declare -f main); main" |& |
There was a problem hiding this comment.
Startup failures skip errored tag
High Severity
Deployment startup now runs main inside a nested sudo/bash subshell piped to logging, while tag_errored and its ERR trap remain on the outer user-data shell. Failures during git, build, or deploy no longer run the trap, so instances can stay tagged StartupBuildProgress=building without errored or nginx stopped.
Reviewed by Cursor Bugbot for commit 8b7813b. Configure here.
| DEPLOYMENT_NAME="$deployment_name" "$deployment_scripts"/connectTailscale.sh | ||
| # Build each package, including injecting environment variables from Bitwarden | ||
| sudo -Hu ubuntu "$deployment_scripts"/buildDeployablePackages.sh "$deployment_name" | ||
| "$deployment_scripts"/buildDeployablePackages.sh "$deployment_name" |
There was a problem hiding this comment.
Preaggregation cron before Node switch
Medium Severity
Production startup still registers the preaggregation crontab before buildDeployablePackages.sh runs nvm install --default for Node 26.4.0, and the job no longer sources nvm explicitly. The cron line embeds whatever PATH was active earlier, often the AMI’s older Node or no nvm paths in non-interactive login shells.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 8b7813b. Configure here.
be2456f to
ad575a8
Compare
88f9414 to
6568260
Compare
6568260 to
615d55f
Compare


Reverts #6851 (which was itself a revert)