Skip to content

Improve "Wait" key usability by making it a "Repeat" like toggle#7434

Draft
Snipebusher wants to merge 4 commits intobeyond-all-reason:masterfrom
Snipebusher:patch-5
Draft

Improve "Wait" key usability by making it a "Repeat" like toggle#7434
Snipebusher wants to merge 4 commits intobeyond-all-reason:masterfrom
Snipebusher:patch-5

Conversation

@Snipebusher
Copy link
Copy Markdown
Contributor

Work done

Keybind presets changes to make the "Wait" keybind more convenient to use when half an army is on wait. This is achieved by changing the keybinds from a toggle to 0 1.

Addresses Issue(s)

Setup

No setup needed.

Test steps

  • In game go to settings -> control -> Keybind preset and change it to Custom. This will generate a file called uikeys.txt in your BAR/data directory (BAR/data/uikeys.txt) with your previous keybinds.
  • Find your preset in the files changed and copy paste it into uikeys.txt overwriting the previous content
  • The changes will be loaded next game, by clicking Custom keybind preset, or by typing /keyreload into chat.
  • Instructions copied and slightly modified from https://discord.com/channels/549281623154229250/1018861299939168288/1477876330384195727

NO TESTING HAS BEEN DONE YET

@github-actions
Copy link
Copy Markdown
Contributor

Integration Test Results

16 tests  ±0   8 ✅ +1   4s ⏱️ -1s
 1 suites ±0   8 💤 ±0 
 1 files   ±0   0 ❌  - 1 

Results for commit 5217fed. ± Comparison against base commit cc90a83.

@TheChronographer
Copy link
Copy Markdown
Collaborator

This is definitely more consistent with the other state based toggles. HOWEVER given the enormous burden in changing existing behaviour for players I can't recommend changing the defaults.

  1. the 2/3 tap behavior is already not clear the new players and the current wait/unwait toggle is easier to understand.

  2. for existing players they are used to the current behavior and changing it now would be confusing.

  3. this is a very simple change in custom keys for those that desire it to be different.

Maybe in the new lobby we should have a quick 'state based' vs 'toggle' setting/option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants