Improve "Wait" key usability by making it a "Repeat" like toggle#7434
Draft
Snipebusher wants to merge 4 commits intobeyond-all-reason:masterfrom
Draft
Improve "Wait" key usability by making it a "Repeat" like toggle#7434Snipebusher wants to merge 4 commits intobeyond-all-reason:masterfrom
Snipebusher wants to merge 4 commits intobeyond-all-reason:masterfrom
Conversation
Contributor
Collaborator
|
This is definitely more consistent with the other state based toggles. HOWEVER given the enormous burden in changing existing behaviour for players I can't recommend changing the defaults.
Maybe in the new lobby we should have a quick 'state based' vs 'toggle' setting/option. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work done
Keybind presets changes to make the "Wait" keybind more convenient to use when half an army is on wait. This is achieved by changing the keybinds from a toggle to 0 1.
Addresses Issue(s)
Setup
No setup needed.
Test steps
Custom. This will generate a file calleduikeys.txtin yourBAR/datadirectory (BAR/data/uikeys.txt) with your previous keybinds.Customkeybind preset, or by typing/keyreloadinto chat.NO TESTING HAS BEEN DONE YET