Coordinated multi unit load/unload + tractorbeam -- test PR by Fx-Doo · Pull Request #7418 · beyond-all-reason/Beyond-All-Reason

Fx-Doo · 2026-04-12T18:51:39Z

This is a WIP -- desc aswell

Use custom script calls (PerformLoad/Unload) and interface between gadget <-> LUS instead of built in engine's script.BeginTransport, passing transportee data along the way.
Set up a cargoHandler resplnsible for unit placement within transport, watching current cargo counts and states, interfacing with gadget through unit rules params
Set up a transport anim handler responsible for the various transport specific animations (tractor beam logic)
set up a generic animation helper that handles generic killed, create, moverate animations.
use customizable setup tables for the different unit.
create the generic lus that loads those setup and handlers
create a shared API: gadget handler <-> API <-> script env

ALREADY FUNCTIONAL:

Loading single unit, unloading single unit, with a tractor beam effect
loading multiple units sequentially, unloading single unit(s) (per unitID) sequencially or multiple units simultaneously
damaging transportees upon death (releaseHeld = true)
rearranging transport layout when loading new units
Override engine cargo handling (size, capacity) (use huge values), and use internal limiters (nSeat and seat sizes), block allowunittransport when the request exceeds those limitations
use either footprint size to get an nseat value for all units or use a customparams value
hover at cruise alt, ignore heading, while loading/unloading
Validate commands as soon as PerformLoad/Unload is called to avoid additional delays

SOON FUNCTIONAL (ready to be implemented but recquires engine changes that have been proposed):

simultaneous multi units load

TO-DOO-LIST:

Massive code cleanup (mainly multiple vars that prolly flag similar situations
pos caching optimizations: since unit is moved in world space (thats a recquirement) but moving a piece is in unitspace, lots of calls for unitpos, rot, pieceposdir on e1ch animated frames. This needs some thought put into optimizing cached data.
live tests as a modoption
Unload preview GUI and walkable check (currently unload pos arent exactly deterministic, it's the cmd's pos + realtime link piece pos offset being applied)
Make a "gather at area load pos" functionality at least for idle units, so they can all fit within load radius instead of causing transport to move from spot to spot.

…pping when reorganize happening + fix reorganize dropping units to ground instead of letting them fly until beam catches them again

…ible offset when loading + stop tracking unit when its position is known to be locked @link piece Sadly, this means i can't just use the cached pos from thread Load()

…another transport

…d both fire UNLOAD_UNIT and not UNLOAD_UNITS, but luckily we can track it via cmdParams[4] being nil

…unit, maybe can write in a GG table instead so all units share same pool?)

github-actions · 2026-04-12T18:55:35Z

Integration Test Results

16 tests ±0 8 ✅ ±0 3s ⏱️ ±0s
1 suites ±0 8 💤 ±0
1 files ±0 0 ❌ ±0

Results for commit 258124e. ± Comparison against base commit 804331e.

♻️ This comment has been updated with latest results.

…engine's alignment and height default goals + use FinishCommand on load cmds

…d functions/values Allows caching some data per unitDefID, and have a single source of truth for unit sizes Log an error if the API was loaded after the script or handler

Fx-Doo · 2026-04-15T09:46:11Z

+	}
+end
+
+if not gadgetHandler:IsSyncedCode() then


Perhaps could actually be synced/unsynced "shared", as those could also benefit gui elements?

…dingRadius but not yet under InRange(); Also delete the "maxHeight" check when checking "InRange" and use lowered internal load_radius

Fx-Doo added 14 commits April 5, 2026 21:26

Air transports tests

7366415

Merge branch 'master' into air-trans-tests

9a7bd6a

some default templates for linkpieces and beampieces positionning.

dbd0cc2

fix multiple LOAD threads on the same piece when reorganizing

61b6480

Fix offset when link pos ~= unitPos in world space + fix load not sto…

c22b7c0

…pping when reorganize happening + fix reorganize dropping units to ground instead of letting them fly until beam catches them again

applied bigger separation (see templates) + added armhvytrans

e1fb95a

Account for unit height on the beam emission process + reduce the vis…

1b1b085

…ible offset when loading + stop tracking unit when its position is known to be locked @link piece Sadly, this means i can't just use the cached pos from thread Load()

when currently ongoing unloading anim, do not accept being loaded by …

9ed2cc5

…another transport

update function to pick unload targets: CustomFormation and AreaUnloa…

61837ee

…d both fire UNLOAD_UNIT and not UNLOAD_UNITS, but luckily we can track it via cmdParams[4] being nil

Use cubic ease in/out curve instead of cosine (still prerendered per …

d4df653

…unit, maybe can write in a GG table instead so all units share same pool?)

speed is in elmos/second, i needed elmos/frame

2109224

msised comment

6ff1246

guard against already unloading units

113f3fe

allow to move a little faster during animation

03852db

Fx-Doo added 2 commits April 15, 2026 10:48

Use Spring.SetUnitMoveGoal after engine called SetGoal() to override …

71cee0a

…engine's alignment and height default goals + use FinishCommand on load cmds

Create an API, loaded before scripts and gadget, for the commonly use…

bc8289e

…d functions/values Allows caching some data per unitDefID, and have a single source of truth for unit sizes Log an error if the API was loaded after the script or handler

Fx-Doo commented Apr 15, 2026

View reviewed changes

Fx-Doo added 2 commits April 15, 2026 12:18

Use the API function, not the deleted cargoHandler version

d7f315c

Optionally, move transporteeID towards transporter when under def.loa…

258124e

…dingRadius but not yet under InRange(); Also delete the "maxHeight" check when checking "InRange" and use lowered internal load_radius

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Coordinated multi unit load/unload + tractorbeam -- test PR#7418

Coordinated multi unit load/unload + tractorbeam -- test PR#7418
Fx-Doo wants to merge 18 commits intobeyond-all-reason:masterfrom
Fx-Doo:air-trans-tests

Fx-Doo commented Apr 12, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Apr 12, 2026 •

edited

Loading

Uh oh!

Fx-Doo Apr 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

Fx-Doo commented Apr 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Apr 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Integration Test Results

Uh oh!

Fx-Doo Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Fx-Doo commented Apr 12, 2026 •

edited

Loading

github-actions bot commented Apr 12, 2026 •

edited

Loading