Skip to content

[Style] bracket-to-dot#7287

Draft
keithharvey wants to merge 1 commit intobeyond-all-reason:masterfrom
keithharvey:mig-bracket
Draft

[Style] bracket-to-dot#7287
keithharvey wants to merge 1 commit intobeyond-all-reason:masterfrom
keithharvey:mig-bracket

Conversation

@keithharvey
Copy link
Copy Markdown
Contributor

@keithharvey keithharvey commented Mar 31, 2026

Part of BAR type-error cleanup. Rebuilds idempotently from master via just bar::fmt-mig-generate.

# bracket-to-dot - convert x["y"] to x.y and ["y"] = to y =
bar-lua-codemod bracket-to-dot --path "$BAR_DIR" --exclude common/luaUtilities

Branch Topology

All branches in the BAR type-error cleanup stack. Regenerated deterministically by just bar::fmt-mig-generate. Generated 2026-04-14 18:57:52 UTC.

Leaves — each targets master, mergeable independently:

Branch Command Diff vs master Units
fmt stylua 1421 files, +178457 −184495 ✅ pass
mig-bracket bar-lua-codemod bracket-to-dot 341 files, +7632 −7632 ✅ pass
mig-rename-aliases bar-lua-codemod rename-aliases 164 files, +352 −352 ✅ pass
mig-detach-bar-modules bar-lua-codemod detach-bar-modules 173 files, +1434 −1301 ✅ pass
mig-i18n bar-lua-codemod i18n-kikito 19 files, +105 −1187 ✅ pass
mig-spring-split bar-lua-codemod spring-split 760 files, +9591 −9587 ✅ pass
mig-integration-tests bar-lua-codemod integration-tests 21 files, +1230 −1151 ✅ pass
mig-busted-types bar-lua-codemod busted-types 12 files, +1501 −0 ✅ pass

Rollups — composite branches stacking the leaves and (for fmt-llm) the env + LLM layers:

Branch Diff vs master Diff vs mig Units
mig 1452 files, +189169 −194574 ✅ pass
fmt-llm 1480 files, +189970 −194795 126 files, +861 −281 ✅ pass

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 31, 2026

Integration Test Results

16 tests  ±0   8 ✅ ±0   4s ⏱️ -1s
 1 suites ±0   8 💤 ±0 
 1 files   ±0   0 ❌ ±0 

Results for commit aa3677b. ± Comparison against base commit d88bed3.

♻️ This comment has been updated with latest results.

Copy link
Copy Markdown
Collaborator

@efrec efrec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some trailing spaces but looks good

@keithharvey
Copy link
Copy Markdown
Contributor Author

keithharvey commented Apr 1, 2026

Some trailing spaces but looks good

Thank you for taking the time Will attempt to address that space issue in the transform now. Right now, I've just shown my work where we can discuss it, but then took like 3 days off, but am about to go through each of these with a more fine tooth comb.

@efrec
Copy link
Copy Markdown
Collaborator

efrec commented Apr 1, 2026

Yeah np I saw it was in draft but I like the change.

@keithharvey keithharvey force-pushed the mig-bracket branch 3 times, most recently from a8e6917 to c572970 Compare April 1, 2026 21:46
@keithharvey keithharvey marked this pull request as ready for review April 1, 2026 21:49
@keithharvey keithharvey changed the title [Types] bracket-to-dot [Style] bracket-to-dot Apr 1, 2026
@keithharvey keithharvey force-pushed the mig-bracket branch 3 times, most recently from c607436 to 0077802 Compare April 3, 2026 19:27
@keithharvey keithharvey marked this pull request as draft April 3, 2026 19:30
@keithharvey keithharvey force-pushed the mig-bracket branch 4 times, most recently from 8216798 to ef17af3 Compare April 4, 2026 16:51
@keithharvey keithharvey force-pushed the mig-bracket branch 2 times, most recently from f4ebf37 to 24993a5 Compare April 12, 2026 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants