Commit feb0dc6
authored
Fix: "The build mesh uniforms pipeline wasn't ready” warning now fires only once (#22398)
# Objective
- Fixes #22358
## Solution
- Use `warn_once` for the log message (and add `bevy_log` as a
dependency for `bevy_pbr`)
## Testing
I added `main.rs` in the reproduction repo
https://github.com/logankaser/bevy-uniforms-pipeline-repro/blob/main/src/main.rs
as an example file in the main `bevy` repo and ran it with `bevy run
--example repro
--features=bevy_camera,bevy_core_pipeline,bevy_log,bevy_pbr,bevy_render,bevy_window,bevy_winit,webgpu
web --open`.
I opened up the app in Chrome and verified in the console log that the
warning only fires once
<details>
<summary>screenshots of console logs</summary>
In google chrome beforehand, you see the spam in the console:
<img width="705" height="285" alt="Screenshot 2026-01-05 at 10 04 57 PM"
src="https://github.com/user-attachments/assets/7fe4cb1c-2df3-4d3b-a80d-4dfdaf2efb68"
/>
After the change, it just warns once:
<img width="728" height="62" alt="Screenshot 2026-01-06 at 12 06 14 AM"
src="https://github.com/user-attachments/assets/c269f10e-1a7f-4daf-a8c8-dc812895eb68"
/>
</details>1 parent 1384bcb commit feb0dc6
2 files changed
+3
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
42 | 42 | | |
43 | 43 | | |
44 | 44 | | |
| 45 | + | |
45 | 46 | | |
46 | 47 | | |
47 | 48 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
| 29 | + | |
29 | 30 | | |
30 | 31 | | |
31 | 32 | | |
| |||
838 | 839 | | |
839 | 840 | | |
840 | 841 | | |
841 | | - | |
| 842 | + | |
842 | 843 | | |
843 | 844 | | |
844 | 845 | | |
| |||
0 commit comments