Implement Zola community fix for broken footnotes#2312
Closed
Rodhlann wants to merge 0 commit intobevyengine:mainfrom
Closed
Implement Zola community fix for broken footnotes#2312Rodhlann wants to merge 0 commit intobevyengine:mainfrom
Rodhlann wants to merge 0 commit intobevyengine:mainfrom
Conversation
Contributor
Author
|
As an additional note, I was reading through the Zola footnote implementation and they attempt to mimic the GitHub style footnotes, example below. (Their function is: I don't think we'd want to touch the Zola reference styles, but the footnotes themselves could look more like GitHub's. I think that's what the original community comment was going for, but I thought it was unsightly. It might be good to follow an existing standard like GitHub though, especially if a future Zola update will use that styling successfully. Test A1 Test B2 (using [^note] word notation) Footnotes |
7ea6638 to
84dfa6b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2205
The Zola footnote behavior is currently broken, as described by this issue: getzola/zola#1070 due to a problem with the underlying pulldown-cmark.
This change addresses the issue using javascript to rebuild the footnote output, per a community suggestion listed in the Zola issue linked above.
As a note, it seems like the underlying issues may have been alleviated and an update to Zola may be possible now: getzola/zola#2896. It might be best to try and push that issue forward ?
Current Behavior (with existing escaped brackets workaround)
Current Behavior (with current Zola footnotes output)
Updated Behavior (with working backlink)