snap server - log enabled/disabled in config overview#10039
Open
macfarla wants to merge 3 commits intobesu-eth:mainfrom
Open
snap server - log enabled/disabled in config overview#10039macfarla wants to merge 3 commits intobesu-eth:mainfrom
macfarla wants to merge 3 commits intobesu-eth:mainfrom
Conversation
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
macfarla
added
the
dev experience
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the configuration overview output to explicitly show whether the SNAP sync server is enabled or disabled when running in SNAP sync mode, improving clarity for node operators.
Changes:
- Add SNAP sync server enabled/disabled line under “Sync mode” when sync mode is SNAP
- Remove the previously unconditional “Snap Sync server enabled” line
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
+481
to
+485
| if (isSnapServerEnabled) { | ||
| lines.add(" SNAP Sync server enabled"); | ||
| } else { | ||
| lines.add(" SNAP Sync server disabled"); | ||
| } |
|
|
||
| if (syncMode != null) { | ||
| lines.add("Sync mode: " + syncMode); | ||
| if (syncMode.equalsIgnoreCase("SNAP")) { |
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
to make it clear for node operators, if sync mode is snap, log whether or not snap server is enabled.
looks like this: