snap - diagnostic logging for malformed RLP messages#10038
Open
macfarla wants to merge 2 commits intobesu-eth:mainfrom
Open
snap - diagnostic logging for malformed RLP messages#10038macfarla wants to merge 2 commits intobesu-eth:mainfrom
macfarla wants to merge 2 commits intobesu-eth:mainfrom
Conversation
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds more diagnostic context to DEBUG logs when malformed RLP is received, specifically including the message code to aid troubleshooting before disconnecting peers.
Changes:
- Include message
codealongside messagedatain malformed-RLP DEBUG logs for Snap and Eth request/response paths - Switch EthProtocolManager malformed-RLP logging to use a throwable cause (
setCause(e)) for stack traces
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/manager/snap/SnapProtocolManager.java | Adds message code to malformed RLP debug log before disconnect |
| ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/manager/RequestManager.java | Adds message code to malformed RLP debug log for responses |
| ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/manager/EthProtocolManager.java | Logs message code + data and attaches exception cause in debug logging |
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
+83
to
87
| "Received malformed message code={} data={} (BREACH_OF_PROTOCOL), disconnecting: {}", | ||
| ethMessage.getData().getCode(), | ||
| ethMessage.getData(), | ||
| peer, | ||
| e); |
...um/eth/src/main/java/org/hyperledger/besu/ethereum/eth/manager/snap/SnapProtocolManager.java
Show resolved
Hide resolved
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
extra logging (at DEBUG) to include message code when incoming RLP is malformed
Fixed Issue(s)
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew spotlessApply./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests