Remove deprecation warning from --block-txs-selection-max-time still used in PoS networks#10037
Merged
macfarla merged 1 commit intobesu-eth:mainfrom Mar 12, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the deprecation messaging around --block-txs-selection-max-time and reframes it as a PoS-specific transaction-selection time limit.
Changes:
- Renamed “non-PoA” transaction selection max time configuration to “PoS” across core config, CLI options, and tests.
- Removed the PoW deprecation prefix from the CLI help text for
--block-txs-selection-max-time. - Updated CLI/config mapping and unit tests to use the new PoS naming.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| ethereum/core/src/main/java/org/hyperledger/besu/ethereum/core/MiningConfiguration.java | Renames default constant and accessor from non-PoA to PoS and updates duration selection logic. |
| app/src/main/java/org/hyperledger/besu/cli/options/MiningOptions.java | Removes deprecation prefix and renames the backing field/mapping to PoS. |
| app/src/test/java/org/hyperledger/besu/cli/options/MiningOptionsTest.java | Updates assertions to new PoS accessor/constant names. |
| ethereum/blockcreation/src/test/java/org/hyperledger/besu/ethereum/blockcreation/LondonFeeMarketBlockTransactionSelectorTest.java | Updates imports/usages to new PoS default constant. |
| ethereum/blockcreation/src/test/java/org/hyperledger/besu/ethereum/blockcreation/AbstractBlockTransactionSelectorTest.java | Updates imports/usages and builder setter to new PoS naming. |
You can also share your feedback on Copilot code review. Take the survey.
ethereum/core/src/main/java/org/hyperledger/besu/ethereum/core/MiningConfiguration.java
Show resolved
Hide resolved
ethereum/core/src/main/java/org/hyperledger/besu/ethereum/core/MiningConfiguration.java
Show resolved
Hide resolved
app/src/main/java/org/hyperledger/besu/cli/options/MiningOptions.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/hyperledger/besu/cli/options/MiningOptions.java
Outdated
Show resolved
Hide resolved
…l used in PoS networks Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
4fcffdd to
8b37408
Compare
macfarla
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
block-txs-selection-max-timeoption can be still used to limit the max time a block selection job can run for PoS networksFixed Issue(s)
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew spotlessApply./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests