Skip to content

Remove deprecation warning from --block-txs-selection-max-time still used in PoS networks#10037

Merged
macfarla merged 1 commit intobesu-eth:mainfrom
fab-10:remove-deprecation-block-txs-selection-max-time
Mar 12, 2026
Merged

Remove deprecation warning from --block-txs-selection-max-time still used in PoS networks#10037
macfarla merged 1 commit intobesu-eth:mainfrom
fab-10:remove-deprecation-block-txs-selection-max-time

Conversation

@fab-10
Copy link
Contributor

@fab-10 fab-10 commented Mar 12, 2026

PR description

block-txs-selection-max-time option can be still used to limit the max time a block selection job can run for PoS networks

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • spotless: ./gradlew spotlessApply
  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests
  • hive tests: Engine or other RPCs modified?

@fab-10 fab-10 marked this pull request as ready for review March 12, 2026 17:38
Copilot AI review requested due to automatic review settings March 12, 2026 17:38
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the deprecation messaging around --block-txs-selection-max-time and reframes it as a PoS-specific transaction-selection time limit.

Changes:

  • Renamed “non-PoA” transaction selection max time configuration to “PoS” across core config, CLI options, and tests.
  • Removed the PoW deprecation prefix from the CLI help text for --block-txs-selection-max-time.
  • Updated CLI/config mapping and unit tests to use the new PoS naming.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
ethereum/core/src/main/java/org/hyperledger/besu/ethereum/core/MiningConfiguration.java Renames default constant and accessor from non-PoA to PoS and updates duration selection logic.
app/src/main/java/org/hyperledger/besu/cli/options/MiningOptions.java Removes deprecation prefix and renames the backing field/mapping to PoS.
app/src/test/java/org/hyperledger/besu/cli/options/MiningOptionsTest.java Updates assertions to new PoS accessor/constant names.
ethereum/blockcreation/src/test/java/org/hyperledger/besu/ethereum/blockcreation/LondonFeeMarketBlockTransactionSelectorTest.java Updates imports/usages to new PoS default constant.
ethereum/blockcreation/src/test/java/org/hyperledger/besu/ethereum/blockcreation/AbstractBlockTransactionSelectorTest.java Updates imports/usages and builder setter to new PoS naming.

You can also share your feedback on Copilot code review. Take the survey.

…l used in PoS networks

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
@fab-10 fab-10 force-pushed the remove-deprecation-block-txs-selection-max-time branch from 4fcffdd to 8b37408 Compare March 12, 2026 17:56
@macfarla macfarla merged commit cb6c762 into besu-eth:main Mar 12, 2026
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants