Deprecate --min-block-occupancy-ratio for removal and make it noop#10036
Draft
fab-10 wants to merge 1 commit intobesu-eth:mainfrom
Draft
Deprecate --min-block-occupancy-ratio for removal and make it noop#10036fab-10 wants to merge 1 commit intobesu-eth:mainfrom
--min-block-occupancy-ratio for removal and make it noop#10036fab-10 wants to merge 1 commit intobesu-eth:mainfrom
Conversation
54b190a to
23ae991
Compare
Contributor
Author
|
@matthew1001 to double check, do you see any issue with this PR? |
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
23ae991 to
71419f7
Compare
Contributor
Author
|
@macfarla do you think this should wait full PoW removal? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
Deprecate
--min-block-occupancy-ratiofor removal and make it noop. That option, that is ignored on PoS networks, is related to the deprecated PoW, and allowed to broadcast a mined block as soon as it reached a satisfying fill threshold. The option is still recognized, but it has no effect and will be completely removed in a future release.Fixed Issue(s)
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew spotlessApply./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests