Skip to content

Deprecate --min-block-occupancy-ratio for removal and make it noop#10036

Draft
fab-10 wants to merge 1 commit intobesu-eth:mainfrom
fab-10:deprecate-min-block-occupancy-ratio
Draft

Deprecate --min-block-occupancy-ratio for removal and make it noop#10036
fab-10 wants to merge 1 commit intobesu-eth:mainfrom
fab-10:deprecate-min-block-occupancy-ratio

Conversation

@fab-10
Copy link
Contributor

@fab-10 fab-10 commented Mar 12, 2026

PR description

Deprecate --min-block-occupancy-ratio for removal and make it noop. That option, that is ignored on PoS networks, is related to the deprecated PoW, and allowed to broadcast a mined block as soon as it reached a satisfying fill threshold. The option is still recognized, but it has no effect and will be completely removed in a future release.

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • spotless: ./gradlew spotlessApply
  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests
  • hive tests: Engine or other RPCs modified?

@fab-10 fab-10 force-pushed the deprecate-min-block-occupancy-ratio branch from 54b190a to 23ae991 Compare March 12, 2026 17:13
@fab-10
Copy link
Contributor Author

fab-10 commented Mar 12, 2026

@matthew1001 to double check, do you see any issue with this PR?

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
@fab-10 fab-10 force-pushed the deprecate-min-block-occupancy-ratio branch from 23ae991 to 71419f7 Compare March 12, 2026 17:24
@fab-10
Copy link
Contributor Author

fab-10 commented Mar 12, 2026

@macfarla do you think this should wait full PoW removal?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant