Skip to content

feat: replace custom logger with nx/devkit logger#64

Merged
michaelbe812 merged 3 commits intomainfrom
feat/use-nx-devkit-logger
Sep 12, 2025
Merged

feat: replace custom logger with nx/devkit logger#64
michaelbe812 merged 3 commits intomainfrom
feat/use-nx-devkit-logger

Conversation

@michaelbe812
Copy link
Copy Markdown
Contributor

Summary

This PR addresses GitHub issue #63 by replacing the custom logger implementation with nx/devkit's official logger to ensure consistency with the Nx ecosystem.

Changes Made

  • Replaced custom Logger class with @nx/devkit logger in all files
  • Updated imports in plugin-loader.ts and validation.ts
  • Fixed logger method calls to match nx/devkit logger API (single argument format)
  • Removed custom logger files (logger.ts, logger.spec.ts)
  • Removed logger export from core package index
  • All tests passing - no breaking changes
  • Linting passes - code quality maintained

API Compatibility

The nx/devkit logger provides all the methods we were using:

  • debug(), info(), warn(), error() - all supported
  • ⚠️ Custom methods like group(), groupEnd(), time(), timeEnd() were only used in tests and have been removed

Test Results

Test Suites: 8 passed, 8 total  
Tests: 147 passed, 147 total
Linting: ✔ All files pass linting

Breaking Changes

None - This is backward compatible. The logger was only used internally and the public API of the core package remains unchanged.

Closes

Fixes #63

🤖 Generated with Claude Code

Mac Mini and others added 3 commits September 12, 2025 09:35
- Replace custom Logger implementation with nx/devkit logger for consistency
- Remove custom logger files (logger.ts, logger.spec.ts)
- Update plugin-loader.ts and validation.ts to use nx/devkit logger
- Fix error logging to use single argument format required by nx/devkit
- Remove logger export from core package index
- All tests passing, no breaking changes

Fixes #63

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
- Fix import in openapi-tools-generator.ts to use @nx/devkit logger
- Remove dependency on removed logger export from @nx-plugin-openapi/core
- All tests now passing across all packages

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@michaelbe812 michaelbe812 merged commit 53c7a69 into main Sep 12, 2025
1 check passed
@michaelbe812 michaelbe812 deleted the feat/use-nx-devkit-logger branch September 12, 2025 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

make sure that logger internally uses the logger from nx/devkit

1 participant