feat: replace custom logger with nx/devkit logger#64
Merged
michaelbe812 merged 3 commits intomainfrom Sep 12, 2025
Merged
Conversation
- Replace custom Logger implementation with nx/devkit logger for consistency - Remove custom logger files (logger.ts, logger.spec.ts) - Update plugin-loader.ts and validation.ts to use nx/devkit logger - Fix error logging to use single argument format required by nx/devkit - Remove logger export from core package index - All tests passing, no breaking changes Fixes #63 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Fix import in openapi-tools-generator.ts to use @nx/devkit logger - Remove dependency on removed logger export from @nx-plugin-openapi/core - All tests now passing across all packages 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses GitHub issue #63 by replacing the custom logger implementation with nx/devkit's official logger to ensure consistency with the Nx ecosystem.
Changes Made
@nx/devkitlogger in all filesplugin-loader.tsandvalidation.tslogger.ts,logger.spec.ts)API Compatibility
The nx/devkit logger provides all the methods we were using:
debug(),info(),warn(),error()- all supportedgroup(),groupEnd(),time(),timeEnd()were only used in tests and have been removedTest Results
Breaking Changes
None - This is backward compatible. The logger was only used internally and the public API of the core package remains unchanged.
Closes
Fixes #63
🤖 Generated with Claude Code