Skip to content

Orv2 5099 bug fix in error message in cart when insufficient available credit#2251

Merged
abhishek-dere merged 10 commits intomainfrom
ORV2-5099-Bug-Fix-in-error-message-in-cart-when-insufficient-available-credit
Mar 24, 2026
Merged

Orv2 5099 bug fix in error message in cart when insufficient available credit#2251
abhishek-dere merged 10 commits intomainfrom
ORV2-5099-Bug-Fix-in-error-message-in-cart-when-insufficient-available-credit

Conversation

@abhishek-dere
Copy link
Collaborator

@abhishek-dere abhishek-dere commented Mar 23, 2026

Description

Scenario: insufficient credit
Given available credit is $500
When staff attempt to pay a $501 transaction
Then they see "Transaction failed. Credit account unavailable."
And they cannot complete the transaction

In this situation, the user is provided a generic error message:
There is no indication in the cart that the problem is with the credit account (this is the same message we see if the permit’s start date is in the past).

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • pay using valid credit account.
  • Test B

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are promoted to:

…099-Bug-Fix-in-error-message-in-cart-when-insufficient-available-credit
Signed-off-by: Abhishek Dere <abhishek.dere@gov.bc.ca>
Updated Trivy action to version v0.35.0 for vulnerability scanning.

Signed-off-by: Abhishek Dere <abhishek.dere@gov.bc.ca>
@sonarqubecloud
Copy link

@sonarqubecloud
Copy link

@sonarqubecloud
Copy link

@sonarqubecloud
Copy link

@sonarqubecloud
Copy link

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed for 'onroutebc frontend'

Failed conditions
5.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@abhishek-dere abhishek-dere merged commit 584cc10 into main Mar 24, 2026
34 of 37 checks passed
@abhishek-dere abhishek-dere deleted the ORV2-5099-Bug-Fix-in-error-message-in-cart-when-insufficient-available-credit branch March 24, 2026 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants