Use linker placeholder for custom Xcode toolchains#1673
Open
bc-lee wants to merge 3 commits intobazelbuild:mainfrom
Open
Use linker placeholder for custom Xcode toolchains#1673bc-lee wants to merge 3 commits intobazelbuild:mainfrom
bc-lee wants to merge 3 commits intobazelbuild:mainfrom
Conversation
rules_swift currently reuses the Swift worker placeholder for linker search paths when TOOLCHAINS selects a custom macOS toolchain. That leaves __BAZEL_SWIFT_TOOLCHAIN_PATH__ unresolved in CppLink actions, which produces a warning during linking. Split the custom toolchain placeholders so Swift-side behavior keeps using __BAZEL_SWIFT_TOOLCHAIN_PATH__ while linker flags use __BAZEL_CUSTOM_XCODE_TOOLCHAIN_PATH__, which apple_support already substitutes for link actions.
bc-lee
requested review from
aaronsky,
adincebic,
brentleyjones,
keith,
luispadron and
mattrobmattrob
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rules_swift currently reuses the Swift worker placeholder for linker search paths when
TOOLCHAINSselects a custom macOS toolchain. That leaves__BAZEL_SWIFT_TOOLCHAIN_PATH__unresolved in CppLink actions, which produces a warning during linking.Split the custom toolchain placeholders so Swift-side behavior keeps using
__BAZEL_SWIFT_TOOLCHAIN_PATH__while linker flags use__BAZEL_CUSTOM_XCODE_TOOLCHAIN_PATH__, whichapple_supportalready substitutes for link actions.Fixes #1672