Add support for compact repo mapping manifest to the runfiles library#1560
Open
cerisier wants to merge 4 commits intobazelbuild:mainfrom
Open
Add support for compact repo mapping manifest to the runfiles library#1560cerisier wants to merge 4 commits intobazelbuild:mainfrom
cerisier wants to merge 4 commits intobazelbuild:mainfrom
Conversation
This implementation follows what others like rules_java have done. Note that the implementation is O(prefix). If performance is an issue, we could probably make that a better with a Trie to replicate NavigableMap.
cerisier
requested review from
BalestraPatrick,
aaronsky,
brentleyjones,
keith,
luispadron,
mattrobmattrob and
thii
as code owners
Contributor
Author
|
Anyone for a review now that 8.4.0 is out ? |
Collaborator
|
FYI, this will be required (by default at least) for Bazel 9: bazelbuild/bazel@244867b |
Contributor
Author
|
Rebased and simplified the lookup logic since prefixes cannot be prefixes of other prefixes so returning the first match is ok here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements bazelbuild/bazel#26262
This implementation follows what others like rules_java have done. Note that the implementation is O(prefix). If performance is an issue, we could probably make that a better with a Trie to replicate NavigableMap.