Workspace: add BlazeResolveConfigurationID to map OCResolveConfigurations to azel configurations#8263
Conversation
…azel configurations # Conflicts: # base/src/com/google/idea/blaze/base/model/BlazeConfigurationData.java
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the handling of configuration identifiers within the Blaze plugin for CLion. By introducing a dedicated Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request refactors how configuration IDs are handled by introducing a new BlazeResolveConfigurationID class to provide a more structured and unique identifier for resolve configurations. The BlazeConfigurationData.get method now directly accepts a configuration ID string, and BlazeCWorkspace uses the new BlazeResolveConfigurationID when adding configurations. A potential compilation error was noted in TransitionTest.java due to a method name mismatch (configurationId() vs configuration()), and the KDoc for the new BlazeResolveConfigurationID class is incomplete.
clwb/tests/headlesstests/com/google/idea/blaze/clwb/TransitionTest.java
Outdated
Show resolved
Hide resolved
cpp/src/com/google/idea/blaze/cpp/BlazeResolveConfigurationID.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
No description provided.