Skip to content

Workspace: add BlazeResolveConfigurationID to map OCResolveConfigurations to azel configurations#8263

Open
LeFrosch wants to merge 4 commits intobazelbuild:masterfrom
LeFrosch:pull/1594b4b8f6e3f338301558db8d1e13a3580b8c2c
Open

Workspace: add BlazeResolveConfigurationID to map OCResolveConfigurations to azel configurations#8263
LeFrosch wants to merge 4 commits intobazelbuild:masterfrom
LeFrosch:pull/1594b4b8f6e3f338301558db8d1e13a3580b8c2c

Conversation

@LeFrosch
Copy link
Copy Markdown
Collaborator

No description provided.

…azel configurations

# Conflicts:
#	base/src/com/google/idea/blaze/base/model/BlazeConfigurationData.java
@LeFrosch LeFrosch marked this pull request as ready for review March 23, 2026 17:19
@LeFrosch LeFrosch requested review from mai93 and ujohnny as code owners March 23, 2026 17:19
@github-actions github-actions bot added product: CLion CLion plugin product: IntelliJ IntelliJ plugin product: GoLand GoLand plugin awaiting-review Awaiting review from Bazel team on PRs labels Mar 23, 2026
@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the handling of configuration identifiers within the Blaze plugin for CLion. By introducing a dedicated BlazeResolveConfigurationID class, it establishes a more robust and explicit mechanism for mapping internal Blaze configuration data to CLion's OCResolveConfiguration unique IDs. This change streamlines configuration lookup and creation, improving the clarity and maintainability of the configuration management logic.

Highlights

  • New Configuration ID Class: Introduced BlazeResolveConfigurationID to provide a standardized, unique identifier for Blaze resolve configurations, facilitating consistent mapping.
  • Simplified Configuration Retrieval: Updated BlazeConfigurationData.get to accept a String configurationId directly, simplifying the process of retrieving Blaze configurations.
  • Consistent ID Generation: Modified BlazeCWorkspace to utilize BlazeResolveConfigurationID when adding new OCResolveConfiguration instances, ensuring consistent ID generation and usage.
  • BlazeResolveConfiguration Enhancement: Added a getUniqueId() method to BlazeResolveConfiguration to return the newly defined BlazeResolveConfigurationID, improving its integration with the new ID system.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors how configuration IDs are handled by introducing a new BlazeResolveConfigurationID class to provide a more structured and unique identifier for resolve configurations. The BlazeConfigurationData.get method now directly accepts a configuration ID string, and BlazeCWorkspace uses the new BlazeResolveConfigurationID when adding configurations. A potential compilation error was noted in TransitionTest.java due to a method name mismatch (configurationId() vs configuration()), and the KDoc for the new BlazeResolveConfigurationID class is incomplete.

LeFrosch and others added 2 commits March 23, 2026 18:46
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@LeFrosch LeFrosch changed the title Add BlazeResolveConfigurationID to map OCResolveConfigurations to azel configurations Workspace: add BlazeResolveConfigurationID to map OCResolveConfigurations to azel configurations Mar 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-review Awaiting review from Bazel team on PRs product: CLion CLion plugin product: GoLand GoLand plugin product: IntelliJ IntelliJ plugin

Projects

Status: Untriaged

Development

Successfully merging this pull request may close these issues.

4 participants