Fix entrypoint: use printenv for hyphenated INPUT_* vars#5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
GitHub Actions passes Docker action inputs with hyphens preserved in the env var name — e.g.
INPUT_OUTPUT-SVG, notINPUT_OUTPUT_SVG. Bash cannot reference hyphenated variable names with${}syntax, so those values were silently empty and--output-svgwas never passed to the binary.The ASCII terminal report still printed (it goes to stdout regardless), but no SVG file was written, so
git-auto-commit-actionfound nothing to commit.Fix
Read the hyphenated env vars via
printenv 'INPUT_OUTPUT-SVG'etc., store them in local bash variables, then build the arg array from those.Test plan
wrote gerrit-heatmap.svgshould appear in the step loggit-auto-commit-actioncommits the file🤖 Generated with Claude Code