Skip to content

Implemented new scrimmaging rules #946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lowtorola merged 2 commits into from
Nov 23, 2025
Merged

Implemented new scrimmaging rules #946

lowtorola merged 2 commits into from
Nov 23, 2025

Conversation

@bmatvey
Copy link
Contributor

@bmatvey bmatvey commented Nov 18, 2025

  • removed old can_scrimmage check from teams/models.py
  • changed create function in compete/views.py to use requested and active scrimmages instead of only counting active scrimmages for rate limiting. Also added error for requesting ranked scrimmages against lower ranked teams.

closes issue #931

@bmatvey bmatvey requested a review from lowtorola November 18, 2025 21:54
lowtorola
lowtorola requested changes Nov 18, 2025
View reviewed changes
Copy link
Contributor

@lowtorola lowtorola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple smol things to tidy up/clarify but then should be GTG! :shipit:

@bmatvey bmatvey requested a review from lowtorola November 23, 2025 17:52
lowtorola
lowtorola approved these changes Nov 23, 2025
View reviewed changes
Copy link
Contributor

@lowtorola lowtorola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@lowtorola lowtorola merged commit 3f824a9 into main Nov 23, 2025
3 checks passed
@lowtorola lowtorola deleted the use_scrimmagerequest branch November 23, 2025 17:58
@lowtorola lowtorola linked an issue Nov 30, 2025 that may be closed by this pull request
Tweak Ranked Scrimmages #931
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lowtorola lowtorola lowtorola approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Tweak Ranked Scrimmages

3 participants

@bmatvey @lowtorola