Allowing for sleep_brightness to be set to 0#1455
Open
jaynis wants to merge 2 commits intobasnijholt:mainfrom
Open
Allowing for sleep_brightness to be set to 0#1455jaynis wants to merge 2 commits intobasnijholt:mainfrom
jaynis wants to merge 2 commits intobasnijholt:mainfrom
Conversation
Signed-off-by: jaynis <kranz.jannis@googlemail.com>
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the
sleep_brightnessrange from 1–100 to 0–100, enabling zero as a valid value. It allows lights to remain off when they receiveturn_oncalls during sleep mode and thus can prevent specific lights (e.g. ceiling lights) from turning on. This eliminates the need of special logic when e.g. turning on lights with motion sensors during night time.