refactor(core): consolidate semantic vector planning#1130
Merged
Conversation
Signed-off-by: phernandez <paul@basicmachines.co>
Signed-off-by: phernandez <paul@basicmachines.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The indexing pipeline had three separate places making semantic-vector planning decisions: embedding job planning, durable project-index resume planning, and oversized-entity shard planning. Keeping those decisions in separate modules made the single and batch paths harder to reason about and evolve consistently.
Part of #1110.
What Changed
EmbeddingIndexPlannerthe canonical owner for target deduplication and fingerprints, batch-job chunking, durable resume plans, and per-entity shard plans.vector_sync_planning.pyimplementation.ProjectIndexRuntimeand repository shard planning through the canonical planner.Implementation Details
Testing
just fast-checkembedding_index_planning.pyat 100% coveragejust fast-test: 78 passed, 1 skipped, 360 deselectedjust package-checkjust doctorgit diff --checkRisks
The main risk is an internal import or behavior drift while moving the durable vector-sync runtime. Focused source, progress, batch, repository, and end-to-end vector-sync tests cover those paths; no public queue payloads or batch-size defaults changed.