refactor(core): extract semantic vector synchronization#1129
Merged
Conversation
Signed-off-by: phernandez <paul@basicmachines.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
SearchRepositoryBasestill mixed backend contracts, semantic retrieval, and nearly 1,000 lines of vector synchronization orchestration.What Changed
semantic_vector_sync.py.search_repository_base.pyfrom 2,058 lines to 1,213 lines while keeping its public and backend override surface as thin delegates.Implementation Details
SearchRepositoryBasecontinues to expose the existing methods so SQLite/Postgres overrides and caller imports do not change.Testing
Automated
just fast-check: passed (ruff, formatting, and type checking; only existing Python 3.14 deprecation warnings).semantic_vector_sync.pyreached 100% line coverage.just fast-test: 552 passed, 2 skipped, 1,262 deselected.just package-check: passed all Claude Code, Codex, skill, Hermes, and OpenClaw package checks.Manual
just doctor: passed the end-to-end local write, index, semantic vector sync, search, and status flow.Risks / Follow-ups
Part of #1108.