Fix SSL validation to allow custom certs without a host/hosts#1793
Open
zacharymarshal wants to merge 1 commit intobasecamp:mainfrom
Open
Fix SSL validation to allow custom certs without a host/hosts#1793zacharymarshal wants to merge 1 commit intobasecamp:mainfrom
zacharymarshal wants to merge 1 commit intobasecamp:mainfrom
Conversation
The proxy validator was rejecting custom SSL cert configurations that didn't include a host. Automatic SSL requires a host/hosts, but using a custom cert (certificate_pem & private_key_pem) should not.
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts proxy SSL validation so that a host/hosts is only required for automatic SSL (ssl: true), not when using custom certificate SSL (ssl: { certificate_pem, private_key_pem }). This aligns validation behavior with documented proxy behavior and enables setups like Cloudflare origin certificates without a host restriction.
Changes:
- Add regression test covering custom SSL cert config without host/hosts.
- Update proxy validator to require host/hosts only when
sslis explicitlytrue(automatic SSL).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
test/configuration/proxy_test.rb |
Adds a test asserting custom-cert SSL config without a host does not raise during validation. |
lib/kamal/configuration/validator/proxy.rb |
Narrows the “host required” validation to only apply to automatic SSL (ssl == true). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The proxy validator was rejecting custom SSL cert configurations that didn't include a host. Automatic SSL requires a host/hosts, but using a custom cert (certificate_pem & private_key_pem) should not.
This allows for things like Cloudflare custom hostnames with origin server certificates.