Skip to content

Push event payload body updates#2628

Open
jhutarek wants to merge 1 commit intomainfrom
push-event-payload-body-update
Open

Push event payload body updates#2628
jhutarek wants to merge 1 commit intomainfrom
push-event-payload-body-update

Conversation

@jhutarek
Copy link

This reopens #2626.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Web Push Notification::EventPayload body strings to provide more informative, action-specific messages (instead of the prior minimal fallback), aligning push notifications better with how mobile/web clients display notification bodies.

Changes:

  • Expand Notification::EventPayload#body to handle additional card actions (triage, sent back to triage, board/collection moves, title changes, postponed/auto-postponed).
  • Add private helpers (column_name, new_location_name, new_title) to extract message details from event.particulars.
  • Add/extend Web push payload tests to cover the new messages and fallback behavior when particulars are missing/blank.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
app/models/notification/event_payload.rb Adds action-specific push notification body text and helper methods to pull details from event.particulars.
test/models/notification/push_target/web_test.rb Adds coverage ensuring Web push payload body matches new action-specific messages and fallbacks.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants