Fix comment JSON URLs using card_id instead of card number#2510
Open
boennemann wants to merge 1 commit intobasecamp:mainfrom
Open
Fix comment JSON URLs using card_id instead of card number#2510boennemann wants to merge 1 commit intobasecamp:mainfrom
boennemann wants to merge 1 commit intobasecamp:mainfrom
Conversation
The comment JSON partial was passing raw `card_id` (opaque UUID) to URL helpers instead of the Card object, bypassing Card#to_param which returns the human-readable number. This produced URLs like `/1/cards/03fk3sowifmraooa9kydlpvod` instead of `/1/cards/21`. Pass the Card object to all URL helpers and expose `card.number` in the nested card object so consumers can reference it. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The comment JSON partial was passing raw
card_id(opaque UUID) to URL helpers instead of the Card object, bypassing Card#to_param which returns the human-readable number. This produced URLs like/1/cards/03fk3sowifmraooa9kydlpvodinstead of/1/cards/21.Pass the Card object to all URL helpers and expose
card.numberin the nested card object so consumers can reference it.