Fix push notification re-subscription when subscriptions expire#2394
Open
waynemsmith wants to merge 1 commit intobasecamp:mainfrom
Open
Fix push notification re-subscription when subscriptions expire#2394waynemsmith wants to merge 1 commit intobasecamp:mainfrom
waynemsmith wants to merge 1 commit intobasecamp:mainfrom
Conversation
This fixes two issues that prevent users from receiving push notifications
after their browser subscription expires (common with Safari):
1. Add pushsubscriptionchange handler to service worker
- When browsers invalidate/expire a push subscription, they fire this event
- Safari is particularly aggressive about expiring subscriptions
- The handler automatically re-subscribes and syncs with the server
2. Show subscribe button when permission granted but no subscription exists
- Previously, if permission was "granted" but the subscription expired,
the UI showed "OFF" but no button to re-subscribe
- Users were stuck unable to re-enable notifications
- Now the button appears when subscription is missing regardless of
permission state
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Member
|
Oops! I hadn't seen this PR when I opened #2421 today. That addressed the 2nd issue: permission is granted, but there's no subscription (or no service worker registered). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes two issues that prevent users from receiving push notifications after their browser subscription expires:
Add
pushsubscriptionchangehandler to service worker - When browsers invalidate/expire a push subscription (Safari does this aggressively, often within 24-72 hours), they fire this event. The handler automatically re-subscribes and syncs with the server.Show subscribe button when permission granted but no subscription exists - Previously, if permission was "granted" but the subscription expired, the UI showed "Push notifications are OFF" but no button to re-subscribe. Users were stuck unable to re-enable notifications.
Problem
Safari is known to expire push subscriptions after periods of inactivity. When this happens:
pushsubscriptionchangeevent fires in the service workerExpiredSubscriptionand deletes the subscriptionTest plan
🤖 Generated with Claude Code