feat: Add TrieDB integration #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrianBland
reviewed
Jan 10, 2026
| reth-trie-common.workspace = true | ||
|
|
||
| # triedb | ||
| #triedb = { git = "https://github.com/base/triedb" } |
There was a problem hiding this comment.
This should probably still point at the git repo, possibly with a specific ref.
|
|
||
| # triedb | ||
| #triedb = { git = "https://github.com/base/triedb" } | ||
| triedb = { path = "/home/andrea/src/triedb" } |
Comment on lines
3225
to
+3226
| self.tx.commit()?; | ||
| self.triedb_tx.commit()?; |
There was a problem hiding this comment.
Confirming that committing mdbx first is safer. If we happen to only commit this but not triedb, we should be able to forward-apply any missing account/storage changes from the last block.
|
|
||
| # Additional dependencies for backend testing | ||
| tempfile.workspace = true | ||
| #triedb = { git = "https://github.com/base/triedb" } |
|
|
||
| # External TrieDB | ||
| #triedb = { git = "https://github.com/base/triedb" } | ||
| triedb = { path = "/home/andrea/src/triedb" } |
|
|
||
| # triedb | ||
| #triedb = { git = "https://github.com/base/triedb" } | ||
| triedb = { path = "/home/andrea/src/triedb" } |
|
|
||
| # triedb | ||
| #triedb = { git = "https://github.com/base/triedb" } | ||
| triedb = { path = "/home/andrea/src/triedb" } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.