Improve "oldest" tox task #191
Open
+15,219
−15,448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ran this successfully with tox locally. I intentionally set all version checks with wrong versions to confirm that tox complains and returns a nonzero exit code in such cases. When fixed, it runs through successfully with zero exit code.
Our Jupyer book is not compatible with Jupyterbook v2's backend. Fix that later. macos-13 is deprecated by Apple and GitHub actions. This leaves us with no testing on Intel-based macs.
Note that Python 3.13 fails with the standard macos-15 runner.
The upper limits on numpy and scipy were set due to issues with the macos-13 runner, which is no longer available. See if we can reset those upper limits.
It looks like prebuilt numpy wheels exist for direct installation.
Updated the cythonize tox task so that it builds the C file using the same numpy version that is presently specified in pyproject.toml. It ran through and generated a different C file. Hard to tell if the differences are substantial. The test suite ran successfully locally with that file.
We are moving forward with using numpy v2.1.2 for builds. This has a bug fix for building numpy from source with macOS. Prebuilt numpy wheels exist for Windows with Python 3.13, but not 3.14.
I'm hoping that we will be able to build 3.14 wheels for everything but Windows.
This included using the latest version of Cython. All tox tasks passing with the new version of the file.
Hopefully the update to numpy v2.1.2 for builds should enable this.
Set all oldest versions to versions that are too old. pip currently updates the version automatically to satisfy surmise's requirements. This should trigger an error in the action since the oldest venv is not as desired/expected.
The action failed as expected.
The previous action failed as expected.
The previous action failed as expected.
All actions failed as intended due to injected bugs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses
Pending task
matern_covmat.cusing new version of numpyTentative PR Self-Review
oldesttox task locally and confirm that it reports failures and successes as expectedoldestversion checking to confirm that action correctly detects and reports failuresNote that the action that builds wheels for releases is only run on commits in
main. After merging, we'll have to confirm that that action runs through.