Fix crash when parsing native stack frames without symbols#278
Merged
Conversation
Add bounds checks in SetNativeStackTraceInformation Add NativeParserTests to validate safe native frame parsing
added 3 commits
April 21, 2026 20:09
…ve_stack_frames_fix # Conflicts: # Runtime/Model/BacktraceRawStackTraceParser.cs
added 5 commits
May 6, 2026 22:57
…mes_fix # Conflicts: # Runtime/Model/BacktraceRawStackTraceParser.cs # Tests/Runtime/Model/BacktraceRawStackTraceParserTests.cs
Collaborator
|
can you link sample BT reports @BartoszLitwiniuk ? |
melekr
reviewed
May 8, 2026
# Conflicts: # Tests/Editor.meta # Tests/Tests.meta
melekr
requested changes
May 12, 2026
melekr
reviewed
May 19, 2026
| return result; | ||
| } | ||
|
|
||
| private BacktraceStackFrame TryParseFrameOrFallback(string frame) |
Collaborator
There was a problem hiding this comment.
how about :
Suggested change
| private BacktraceStackFrame TryParseFrameOrFallback(string frame) | |
| private BacktraceStackFrame TryParseFrameOrFallback(string frame) | |
| { | |
| try | |
| { | |
| string frameString = frame.Trim(); | |
| if (frameString.StartsWith("0x", StringComparison.Ordinal)) | |
| { | |
| return ParseNativeFrame(frameString); | |
| } | |
| if (frameString.StartsWith("#", StringComparison.Ordinal)) | |
| { | |
| return SetJITStackTraceInformation(frameString); | |
| } | |
| int methodNameEndIndex = frameString.IndexOf(')'); | |
| if (methodNameEndIndex == -1) | |
| { | |
| return new BacktraceStackFrame | |
| { | |
| FunctionName = frame, | |
| InvalidFrame = true | |
| }; | |
| } | |
| int openParentIndex = frameString.LastIndexOf('(', methodNameEndIndex); | |
| if (openParentIndex == -1 || openParentIndex > methodNameEndIndex) | |
| { | |
| return new BacktraceStackFrame | |
| { | |
| FunctionName = frame, | |
| InvalidFrame = true | |
| }; | |
| } | |
| return ParseStacktraceFrame(frameString, methodNameEndIndex); | |
| } | |
| catch | |
| { | |
| return new BacktraceStackFrame | |
| { | |
| FunctionName = frame, | |
| InvalidFrame = true | |
| }; | |
| } | |
| } |
melekr
approved these changes
May 19, 2026
Collaborator
melekr
left a comment
There was a problem hiding this comment.
lgtm.
let's add the tests as discussed.
melekr
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a crash in the native stack trace parser when frames are missing symbol information. Refactors BacktraceRawStackTraceParser for safer parsing and adds unit test coverage.
It's a follow up of changes made in #258 and bug
BT-5953.Changes
SetNativeStackTraceInformationto prevent out-of-range access when a native frame lacks symbol dataBacktraceRawStackTraceParserfor clearer, more defensive frame parsingBacktraceRawStackTraceParserTestscovering native frame parsing edge casesBacktraceRawStackTraceParserinBacktraceUnhandledExceptioninstead of mixing unhandled exception handler with parsing logicTesting