CMake: set cmake_minimum_required to 3.10#62
Merged
bab2min merged 2 commits intobab2min:mainfrom Jan 31, 2026
Merged
Conversation
Contributor
Author
|
rebased, and bumped googletest tag to fix ci: |
c571141 to
52d2c5e
Compare
to be more future-proof, as we currently have this warning: ``` CMake Deprecation Warning at CMakeLists.txt:1 (cmake_minimum_required): Compatibility with CMake < 3.10 will be removed from a future version of CMake. Update the VERSION argument <min> value. Or, use the <min>...<max> syntax to tell CMake that the project requires at least <min> but has been updated to work with policies introduced by <max> or earlier. ``` For reference, the current oldest maintained debian already has CMake 3.18, from 2020. CMake 3.10 is from 2018.
This is the first version that will work with CMake v4: google/googletest#4288
Owner
|
@nim65s |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi again,
To be more future-proof, I thinks this should be updated, as we currently have this warning:
For reference, the current oldest maintained debian already has CMake 3.18, from 2020. CMake 3.10 is from 2018.