Skip to content

CMake: set cmake_minimum_required to 3.10#62

Merged
bab2min merged 2 commits intobab2min:mainfrom
nim65s:cmake
Jan 31, 2026
Merged

CMake: set cmake_minimum_required to 3.10#62
bab2min merged 2 commits intobab2min:mainfrom
nim65s:cmake

Conversation

@nim65s
Copy link
Copy Markdown
Contributor

@nim65s nim65s commented Oct 29, 2025

Hi again,

To be more future-proof, I thinks this should be updated, as we currently have this warning:

CMake Deprecation Warning at CMakeLists.txt:1 (cmake_minimum_required):
  Compatibility with CMake < 3.10 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax
  to tell CMake that the project requires at least <min> but has been updated
  to work with policies introduced by <max> or earlier.

For reference, the current oldest maintained debian already has CMake 3.18, from 2020. CMake 3.10 is from 2018.

@nim65s
Copy link
Copy Markdown
Contributor Author

nim65s commented Oct 29, 2025

rebased, and bumped googletest tag to fix ci:

-- FETCHCONTENT_SOURCE_DIR_GOOGLETEST: /home/runner/work/EigenRand/EigenRand/googletest
CMake Error at googletest/CMakeLists.txt:1 (cmake_minimum_required):
  Compatibility with CMake < 3.5 has been removed from CMake.

to be more future-proof, as we currently have this warning:
```
CMake Deprecation Warning at CMakeLists.txt:1 (cmake_minimum_required):
  Compatibility with CMake < 3.10 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax
  to tell CMake that the project requires at least <min> but has been updated
  to work with policies introduced by <max> or earlier.
```

For reference, the current oldest maintained debian already has CMake
3.18, from 2020. CMake 3.10 is from 2018.
This is the first version that will work with CMake v4:
google/googletest#4288
@bab2min
Copy link
Copy Markdown
Owner

bab2min commented Jan 31, 2026

@nim65s
It seems to work well. Thank you for your contribution. I'll merge it.

@bab2min bab2min merged commit 2a58091 into bab2min:main Jan 31, 2026
133 of 136 checks passed
@nim65s nim65s deleted the cmake branch January 31, 2026 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants