feat(Core/SmartScripts): Implement Target Type for Formations (#3679)

Co-authored-by: Helias <stefanoborzi32@gmail.com>

Author: Gultask

libs/shared/sai-editor/src/constants/sai-targets.ts

@@ -36,6 +36,7 @@ export enum SAI_TARGETS {
   ROLE_SELECTION = 203,
   SUMMONED_CREATURES = 204,
   INSTANCE_STORAGE = 205,
+  FORMATION = 206,
 }
 
 export const SAI_TARGETS_KEYS = getEnumKeys(SAI_TARGETS);
@@ -312,3 +313,12 @@ SAI_TARGET_TOOLTIPS[SAI_TARGETS.INSTANCE_STORAGE] = '';
 SAI_TARGET_PARAM1_NAMES[SAI_TARGETS.INSTANCE_STORAGE] = 'Data Index';
 SAI_TARGET_PARAM2_NAMES[SAI_TARGETS.INSTANCE_STORAGE] = 'Type';
 SAI_TARGET_PARAM2_TOOLTIPS[SAI_TARGETS.INSTANCE_STORAGE] = 'creature (1), gameobject (2)';
+
+// SMART_TARGET_FORMATION
+SAI_TARGET_TOOLTIPS[SAI_TARGETS.FORMATION] = 'Targets members of the creature\'s formation group (creature_formations table). Dead members are excluded.';
+SAI_TARGET_PARAM1_NAMES[SAI_TARGETS.FORMATION] = 'Type';
+SAI_TARGET_PARAM2_NAMES[SAI_TARGETS.FORMATION] = 'CreatureEntry';
+SAI_TARGET_PARAM3_NAMES[SAI_TARGETS.FORMATION] = 'ExcludeSelf';
+SAI_TARGET_PARAM1_TOOLTIPS[SAI_TARGETS.FORMATION] = '0: members only, 1: leader only, 2: all';
+SAI_TARGET_PARAM2_TOOLTIPS[SAI_TARGETS.FORMATION] = '0: any entry';
+SAI_TARGET_PARAM3_TOOLTIPS[SAI_TARGETS.FORMATION] = '(0/1) exclude this creature';

libs/shared/sai-editor/src/sai-comment-generator.service.spec.ts

@@ -1139,6 +1139,14 @@ describe('SaiCommentGeneratorService', () => {
         },
         expected: `MockEntity - In Combat - Move To Loot Recipients`,
       },
+      {
+        name: `SAI_ACTIONS.MOVE_TO_POS check target type (unsupported target type)`,
+        input: {
+          action_type: SAI_ACTIONS.MOVE_TO_POS,
+          target_type: 99999,
+        },
+        expected: `MockEntity - In Combat - Move To [unsupported target type]`,
+      },
       {
         name: `SAI_ACTIONS.GO_SET_LOOT_STATE check action param 1 (0)`,
         input: {
@@ -1961,6 +1969,15 @@ describe('SaiCommentGeneratorService', () => {
         },
         expected: `MockEntity - In Combat - Move To Instance Storage`,
       },
+      {
+        name: `SAI_ACTIONS.MOVE_TO_POS check target type (SAI_TARGETS.FORMATION)`,
+        input: {
+          action_type: SAI_ACTIONS.MOVE_TO_POS,
+          target_type: SAI_TARGETS.FORMATION,
+          target_param1: 0,
+        },
+        expected: `MockEntity - In Combat - Move To Formation`,
+      },
       {
         name: `SAI_ACTIONS.MOVE_TO_POS check target type (unsupported target type)`,
         input: {

libs/shared/sai-editor/src/sai-comment-generator.service.ts

@@ -91,6 +91,8 @@ export class SaiCommentGeneratorService {
         return 'Summoned Creatures';
       case SAI_TARGETS.INSTANCE_STORAGE:
         return 'Instance Storage';
+      case SAI_TARGETS.FORMATION:
+        return 'Formation';
       default:
         return '[unsupported target type]';
     }