fix(query): add missing semi-colon for multi-key statements (#3677)

Author: sogladev

libs/shared/db-layer/src/query/mysql-query.service.spec.ts

@@ -690,21 +690,21 @@ describe('MysqlQueryService', () => {
           currentRow: { k1: 1, k2: 2 },
           newRow: { k1: 11, k2: 2 },
           keys: ['k1', 'k2'],
-          query: 'UPDATE `my_table` SET `k1` = 11 WHERE (`k1` = 1) AND (`k2` = 2)',
+          query: 'UPDATE `my_table` SET `k1` = 11 WHERE (`k1` = 1) AND (`k2` = 2);',
         },
         {
           id: 3,
           currentRow: { k1: 1, k2: 2, k3: 3, n1: 1 },
           newRow: { k1: 1, k2: 2, k3: 3, n1: 11 },
           keys: ['k1', 'k2', 'k3'],
-          query: 'UPDATE `my_table` SET `n1` = 11 WHERE (`k1` = 1) AND (`k2` = 2) AND (`k3` = 3)',
+          query: 'UPDATE `my_table` SET `n1` = 11 WHERE (`k1` = 1) AND (`k2` = 2) AND (`k3` = 3);',
         },
         {
           id: 4,
           currentRow: { k1: 1, k2: 2, k3: 3, n1: 1 },
           newRow: { k1: 1, k2: 2, k3: 33, n1: 11 },
           keys: ['k1', 'k2', 'k3'],
-          query: 'UPDATE `my_table` SET `k3` = 33, `n1` = 11 WHERE (`k1` = 1) AND (`k2` = 2) AND (`k3` = 3)',
+          query: 'UPDATE `my_table` SET `k3` = 33, `n1` = 11 WHERE (`k1` = 1) AND (`k2` = 2) AND (`k3` = 3);',
         },
       ]) {
         it(`should correctly generate the query [${id}]`, () => {
@@ -715,19 +715,19 @@ describe('MysqlQueryService', () => {
 
     describe('getDeleteMultipleKeysQuery', () => {
       for (const { id, row, keys, query } of [
-        { id: 0, row: {}, keys: [], query: 'DELETE FROM `my_table`' },
-        { id: 1, row: { k1: 1 }, keys: ['k1'], query: 'DELETE FROM `my_table` WHERE (`k1` = 1)' },
+        { id: 0, row: {}, keys: [], query: 'DELETE FROM `my_table`;' },
+        { id: 1, row: { k1: 1 }, keys: ['k1'], query: 'DELETE FROM `my_table` WHERE (`k1` = 1);' },
         {
           id: 2,
           row: { k1: 1, k2: 2 },
           keys: ['k1', 'k2'],
-          query: 'DELETE FROM `my_table` WHERE (`k1` = 1) AND (`k2` = 2)',
+          query: 'DELETE FROM `my_table` WHERE (`k1` = 1) AND (`k2` = 2);',
         },
         {
           id: 3,
           row: { k1: 1, k2: 2, k3: 3 },
           keys: ['k1', 'k2', 'k3'],
-          query: 'DELETE FROM `my_table` WHERE (`k1` = 1) AND (`k2` = 2) AND (`k3` = 3)',
+          query: 'DELETE FROM `my_table` WHERE (`k1` = 1) AND (`k2` = 2) AND (`k3` = 3);',
         },
       ]) {
         it(`should correctly generate the query [${id}]`, () => {

libs/shared/db-layer/src/query/mysql-query.service.ts

@@ -290,7 +290,7 @@ export class MysqlQueryService extends BaseQueryService {
       return '';
     }
     this.addWhereConditionsToQuery(updateQuery, currentRow, primaryKeys);
-    return updateQuery.toString();
+    return updateQuery.toString() + ';';
   }
 
   // Generates the DELETE query of ONE row using more than 2 keys
@@ -301,7 +301,7 @@ export class MysqlQueryService extends BaseQueryService {
   ) {
     const deleteQuery: Delete = squel.delete(squelConfig).from(tableName);
     this.addWhereConditionsToQuery(deleteQuery, row, primaryKeys);
-    return deleteQuery.toString();
+    return deleteQuery.toString() + ';';
   }
 
   // Generates the full DELETE/INSERT query of ONE row using more than 2 keys
@@ -312,7 +312,7 @@ export class MysqlQueryService extends BaseQueryService {
     primaryKeys: string[], // array of the primary keys
   ) {
     const insertQuery: Insert = squel.insert(squelConfig).into(tableName).setFieldsRows([newRow]);
-    let query: string = this.getDeleteMultipleKeysQuery(tableName, currentRow, primaryKeys) + ';\n';
+    let query: string = this.getDeleteMultipleKeysQuery(tableName, currentRow, primaryKeys) + '\n';
     query += insertQuery.toString() + ';\n';
     return this.formatQuery(query);
   }