Fix that the function libzbc_report_zones fails prematurely when encountering SOBR zone types if using libzbc engine#2083
Fix that the function libzbc_report_zones fails prematurely when encountering SOBR zone types if using libzbc engine#2083rorychen wants to merge 1 commit intoaxboe:masterfrom
Conversation
|
@rorychen please investigate the build errors. |
|
Hi Vincent, I fixed it and verified the compile on bench. Sorry for wrong characters in last code. |
| ZBD_ZONE_TYPE_SWR = 0x2, /* Sequential write required */ | ||
| ZBD_ZONE_TYPE_SWP = 0x3, /* Sequential write preferred */ | ||
| ZBD_ZONE_TYPE_SOBR = 0x4, /* Sequential Of Before Required */ | ||
| ZBD_ZONE_TYPE_SOBR = 0x4, /* Sequential Of Before Required */ |
There was a problem hiding this comment.
While at it, please fix the typo: Sequential or Before Required
Also, this patch should be folded into the previous one.
damien-lemoal
left a comment
There was a problem hiding this comment.
The patch title does not make sense given the changes. All I see is that you are handling the SOBR zone type as a valid one, but there is nothing related to "running" nor to "SWR" in these changes.
Furthermore, "Hybrid SMR" is not a technical/standard term. Please refer to ZBC/ZAC "Zone Domains" or "Zone Realms" feature.
Finally, your patch also has not commit message nor a Signed-off-by tag. The commit message should really be added to explain what is missing and how your change improves support for Zone Domains/Zone Realms drives.
…untering SOBR zone types if using libzbc engine. With the fix, fio will not quit early when reading the zone informatio from SATA HDD drives with Zone Domain features enabled.
Thanks for the suggestion. Yes, it's not for the fix related to SWR and the patch title is not accurate. I reword the commit message and combine 2 commits to one new commit. The background is that I'd like to run fio with libzbc engine on SWR zones on a SATA HDD drive with Zone Domain feature enabled but fio aborted unexpectedly. The reason is that current function libzbc_report_zones lacks the handling for SOBR zone type so fio would quit early when processing zone information after reporting the zones from one SATA HDD with Zone Domain feature enabled. |
|
Your patch format is not correct: the entire commit message is the commit title. Please see "git log" for examples of correctly formatted commits: the first line is the title, followed by a blank line and the commit message. After that, add a blank line and your Signed-off-by tag. |
Support random write on SWR zones on Hybrid SMR drives with libzbc engine
Hybrid SMR has SWR zones. This change can support libzbc engine to run random write workload on SWR zones of Hybrid SMR drives. Require libzbc revision >= 6.0.
Signed-off-by: Rory Chen rory.c.chen@seagate.com