Skip to content

Fix docs, consolidate scripts, and separate dev ports in lexical-graph-hybrid-dev#199

Open
mykola-pereyma wants to merge 3 commits intoawslabs:mainfrom
mykola-pereyma:fix/docs-lexical-graph-hybrid-dev
Open

Fix docs, consolidate scripts, and separate dev ports in lexical-graph-hybrid-dev#199
mykola-pereyma wants to merge 3 commits intoawslabs:mainfrom
mykola-pereyma:fix/docs-lexical-graph-hybrid-dev

Conversation

@mykola-pereyma
Copy link
Copy Markdown
Contributor

Summary

Fixes documentation issues, consolidates redundant Docker scripts into a single entry point, and separates dev/standard ports to allow simultaneous operation.

Changes

Documentation & Notebooks

  • Fix stale model references (→ Claude Sonnet 4), role names (→ bedrock-batch-inference-role), and env source (→ notebooks/.env.template)
  • Fix truncated variable in create_prompt_role.ps1 ($tem$tempTrustPolicyFile)
  • Fix broken doc links in notebook 01, hardcoded key_prefix in notebook 03, 'Netune' typo in notebook 04
  • Fix neo4j://bolt:// protocol in README
  • Add missing DynamoDB step and fix numbering in setup-bedrock-batch-doc.md
  • Add dev services comparison table to docker_services.md

Script Consolidation

  • Remove 7 redundant scripts: dev-start.sh, dev-reset.sh, reset.sh, build.sh, start-containers.bat, create_custom_prompt.bat
  • All functionality consolidated into start-containers.sh / .ps1 with --dev, --reset, --mac flags
  • --dev now switches to docker-compose-dev.yml (previously exported unused env var)
  • --reset cleans extracted/ directory for fresh start

Docker

  • Remove unused mysql service from dev compose
  • Move Dockerfile.jupyterjupyter/Dockerfile.dev
  • Separate dev ports (pgvector 5434, jupyter 8890) from standard (5433, 8889) to allow running both simultaneously

Testing

All changes tested end-to-end in dev mode on macOS:

  • All 5 Docker startup modes verified (standard, --mac, --dev, --dev --mac, --reset)
  • All 3 AWS scripts executed successfully (setup-bedrock-batch, create_prompt_role, create_custom_prompt)
  • All 40 notebook cells across 5 notebooks executed via papermill — 39/40 passed, 1 skipped (CUDA/GPU)
  • 3 cohesion review passes with explorer agent — all issues resolved

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Comment thread examples/lexical-graph-hybrid-dev/docs/aws_integration.md
@mykola-pereyma mykola-pereyma force-pushed the fix/docs-lexical-graph-hybrid-dev branch from 960c69d to fab4ae9 Compare April 17, 2026 22:34
- Update model names to Claude Sonnet 4, fix role name references
- Fix neo4j:// to bolt:// protocol in README
- Add DynamoDB step to setup-bedrock-batch-doc.md
- Fix broken doc links in notebook cells
- Replace hardcoded key_prefix with env var in Cloud-Build notebook
- Fix truncated variable in create_prompt_role.ps1
Scripts:
- Remove redundant scripts (dev-start.sh, dev-reset.sh, reset.sh,
  build.sh, .bat files) — superseded by start-containers.sh flags
- start-containers.sh/ps1: Add --dev (switches to dev compose),
  --reset (with extracted/ cleanup), correct port output per mode
- Add note when --reset used without --dev

Docker:
- docker-compose-dev.yml: Remove mysql, separate ports (5434, 8890)
- Move Dockerfile.jupyter to jupyter/Dockerfile.dev

Docs:
- docker_startup_scripts.md: Remove deleted script sections
- docker_services.md: Add dev services comparison table
- Auto-attach identity policy to caller's IAM role for non-SSO users
- Remove create_custom_prompt.bat (PowerShell version covers Windows)
@mykola-pereyma mykola-pereyma force-pushed the fix/docs-lexical-graph-hybrid-dev branch from fab4ae9 to a56c198 Compare April 17, 2026 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants