Remove global.localStorage call in paho-mqtt file for incognito mode#582
Open
ekarious wants to merge 1 commit intoawslabs:masterfrom
ekarious:fix/mqtt-localstorage-incognito-mode
Open
Remove global.localStorage call in paho-mqtt file for incognito mode#582ekarious wants to merge 1 commit intoawslabs:masterfrom ekarious:fix/mqtt-localstorage-incognito-mode
global.localStorage call in paho-mqtt file for incognito mode#582ekarious wants to merge 1 commit intoawslabs:masterfrom
ekarious:fix/mqtt-localstorage-incognito-mode
Conversation
… default forbidden
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was the problem ?
paho-mqtt.jswas using the codeglobal.localStorage.In Private navigation (aka incognito mode), cookies are by default blocked for third party. The fallback was to use localStorage but this file is attaching localStorage to global and access to the global window is forbidden which resulted in an error.
DOMException: Failed to read the 'localStorage' property from 'Window': Access is denied for this documentWhy this modification:
Remove this little piece of code will allow
aws-appsyncto be correctly used even in private navigation.