Bugfix: add schema to join for column comments#708
Open
mkellar3 wants to merge 1 commit intoawslabs:masterfrom
Open
Bugfix: add schema to join for column comments#708mkellar3 wants to merge 1 commit intoawslabs:masterfrom
mkellar3 wants to merge 1 commit intoawslabs:masterfrom
Conversation
leisersohn
approved these changes
Aug 8, 2024
Contributor
leisersohn
left a comment
leisersohn
left a comment
There was a problem hiding this comment.
Tested the fix, it solves the bug mentioned
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#707
Description of changes:
Add schema to the join condition when getting column comments to avoid getting column comments on table with same name from another schema
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.