Skip to content

Migrate 03-registry samples from preview to GA API - #1889

Open
ach1ntya wants to merge 1 commit into
awslabs:mainfrom
ach1ntya:main
Open

Migrate 03-registry samples from preview to GA API#1889
ach1ntya wants to merge 1 commit into
awslabs:mainfrom
ach1ntya:main

Conversation

@ach1ntya

@ach1ntya ach1ntya commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Amazon Bedrock AgentCore Samples Pull Request

Important

  1. We strictly follow a issue-first approach, please first open an issue relating to this Pull Request.
  2. Once this Pull Request is ready for review please attach review ready label to it. Only PRs with review ready will be reviewed.

Issue number:

Concise description of the PR

Updates all files in 01-features/07-centralize-and-govern-your-ai-infrastructure/03-registry/ to use the GA Agent Registry API namespace and shapes. 

User experience

No changes. The output of the samples is the same, the code is just updated to work with the new GA API namespace and shapes.

Checklist

If your change doesn't seem to apply, please leave them unchecked.

  • I have reviewed the contributing guidelines
  • Add your name to CONTRIBUTORS.md
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Are you uploading a dataset?
  • Have you documented Introduction, Architecture Diagram, Prerequisites, Usage, Sample Prompts, and Clean Up steps in your example README?
  • I agree to resolve any issues created for this example in the future.
  • I have performed a self-review of this change
  • Changes have been tested
  • Changes are documented

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.

@ach1ntya
ach1ntya marked this pull request as ready for review August 4, 2026 04:31
@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown

Latest scan for commit: 77813cd | Updated: 2026-08-04 17:04:53 UTC

Security Scan Results

Scan Metadata

  • Project: ASH
  • Scan executed: 2026-08-04T17:01:31+00:00
  • ASH version: 3.0.0

Summary

Scanner Results

The table below shows findings by scanner, with status based on severity thresholds and dependencies:

Column Explanations:

Severity Levels (S/C/H/M/L/I):

  • Suppressed (S): Security findings that have been explicitly suppressed/ignored and don't affect the scanner's pass/fail status
  • Critical (C): The most severe security vulnerabilities requiring immediate remediation (e.g., SQL injection, remote code execution)
  • High (H): Serious security vulnerabilities that should be addressed promptly (e.g., authentication bypasses, privilege escalation)
  • Medium (M): Moderate security risks that should be addressed in normal development cycles (e.g., weak encryption, input validation issues)
  • Low (L): Minor security concerns with limited impact (e.g., information disclosure, weak recommendations)
  • Info (I): Informational findings for awareness with minimal security risk (e.g., code quality suggestions, best practice recommendations)

Other Columns:

  • Time: Duration taken by each scanner to complete its analysis
  • Action: Total number of actionable findings at or above the configured severity threshold that require attention

Scanner Results:

  • PASSED: Scanner found no security issues at or above the configured severity threshold - code is clean for this scanner
  • FAILED: Scanner found security vulnerabilities at or above the threshold that require attention and remediation
  • MISSING: Scanner could not run because required dependencies/tools are not installed or available
  • SKIPPED: Scanner was intentionally disabled or excluded from this scan
  • ERROR: Scanner encountered an execution error and could not complete successfully

Severity Thresholds (Thresh Column):

  • CRITICAL: Only Critical severity findings cause scanner to fail
  • HIGH: High and Critical severity findings cause scanner to fail
  • MEDIUM (MED): Medium, High, and Critical severity findings cause scanner to fail
  • LOW: Low, Medium, High, and Critical severity findings cause scanner to fail
  • ALL: Any finding of any severity level causes scanner to fail

Threshold Source: Values in parentheses indicate where the threshold is configured:

  • (g) = global: Set in the global_settings section of ASH configuration
  • (c) = config: Set in the individual scanner configuration section
  • (s) = scanner: Default threshold built into the scanner itself

Statistics calculation:

  • All statistics are calculated from the final aggregated SARIF report
  • Suppressed findings are counted separately and do not contribute to actionable findings
  • Scanner status is determined by comparing actionable findings to the threshold
Scanner S C H M L I Time Action Result Thresh
bandit 0 3 0 0 26 0 1.8s 3 FAILED MED (g)
cdk-nag 0 0 0 0 0 0 8.6s 0 PASSED MED (g)
cfn-nag 0 0 0 0 0 0 28ms 0 PASSED MED (g)
checkov 0 0 0 0 0 0 6.7s 0 PASSED MED (g)
detect-secrets 0 0 0 0 0 0 1.6s 0 PASSED MED (g)
grype 0 0 0 0 0 0 56.3s 0 PASSED MED (g)
npm-audit 0 0 0 0 0 0 281ms 0 PASSED MED (g)
opengrep 0 0 0 0 0 0 <1ms 0 SKIPPED MED (g)
semgrep 0 0 0 0 0 0 <1ms 0 MISSING MED (g)
syft 0 0 0 0 0 0 2.9s 0 PASSED MED (g)

Detailed Findings

Show 3 actionable findings

Finding 1: B108

  • Severity: HIGH
  • Scanner: bandit
  • Rule ID: B108
  • Location: 01-features/07-centralize-and-govern-your-ai-infrastructure/03-registry/03-advanced/strands-mcp-ecs-registry/deploy/agent/agent.py:65-67

Description:
Probable insecure usage of temp file/directory.

Code Snippet:

COGNITO_JWKS_URL = _raw_jwks if _raw_jwks.startswith("https://") else ""  # skip JWT if not a real URL
LOADED_SKILLS_DIR = "/tmp/loaded_skills"

Finding 2: B310

  • Severity: HIGH
  • Scanner: bandit
  • Rule ID: B310
  • Location: 01-features/07-centralize-and-govern-your-ai-infrastructure/03-registry/03-advanced/strands-mcp-ecs-registry/deploy/agent/agent.py:479-481

Description:
Audit url open for permitted schemes. Allowing use of file:/ or custom schemes is often unexpected.

Code Snippet:

with urllib.request.urlopen(COGNITO_JWKS_URL, timeout=5) as r:
            _jwks_cache = json.loads(r.read())

Finding 3: B104

  • Severity: HIGH
  • Scanner: bandit
  • Rule ID: B104
  • Location: 01-features/07-centralize-and-govern-your-ai-infrastructure/03-registry/03-advanced/strands-mcp-ecs-registry/deploy/agent/agent.py:804-805

Description:
Possible binding to all interfaces.

Code Snippet:

port = int(os.environ.get("PORT", "8080"))
    uvicorn.run(app, host="0.0.0.0", port=port, log_level="info")

Report generated by Automated Security Helper (ASH) at 2026-08-04T17:01:26+00:00

@ach1ntya
ach1ntya force-pushed the main branch 3 times, most recently from 241eca2 to 45c8da9 Compare August 4, 2026 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant