Skip to content

fix: Remove third-party check-user-permission action from e2e workflow #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elamaran11 merged 1 commit into from
May 19, 2026
Merged

fix: Remove third-party check-user-permission action from e2e workflow #196

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 4 additions & 17 deletions .github/workflows/e2e.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,24 +3,15 @@ on:
issue_comment:
types: [created]
jobs:
checkPermissions:
runs-on: ubuntu-latest
if: github.event.issue.pull_request && contains(github.event.comment.body, '/do-e2e-test') # check the comment if it contains the keywords
steps:
- id: checkUserPermissions
uses: actions-cool/check-user-permission@main
with:
require: 'admin'
outputs:
run_test: ${{ steps.checkUserPermissions.outputs.require-result }}
e2ePipeline:
runs-on: ubuntu-latest
permissions:
id-token: write
contents: read
if: github.event.issue.pull_request && contains(github.event.comment.body, '/do-e2e-test') && needs.checkPermissions.outputs.run_test == 'true'
needs:
- checkPermissions
if: >
github.event.issue.pull_request &&
contains(github.event.comment.body, '/do-e2e-test') &&
contains(fromJSON('["OWNER", "MEMBER"]'), github.event.comment.author_association)
steps:
- name: Dump GitHub context
env:
Expand All @@ -47,10 +38,6 @@ jobs:
uses: aws-actions/aws-codebuild-run-build@v1
with:
project-name: cdk-pattern-test
# buildspec-override: path/to/buildspec.yaml or inline buildspec definition
# compute-type-override: compute-type
# environment-type-override: environment-type
# image-override: ecr-image-uri
env-vars-for-codebuild: |
PR_NUMBER,
COMMIT_ID,
Expand Down
Loading