Test to verify numa balancing by verifying numa_pte_updates and numa_hint_faults#3061
Conversation
…hint_faults Test enables and disables numa_balancing by writing to /proc/sys/kernel/numa_balancing and verifies numa_pte_updates and numa_hint_faults Signed-off-by: Pavithra <pavrampu@linux.ibm.com>
memory/autonuma.py
Outdated
| """ | ||
| cmd = 'cat /proc/vmstat | grep numa_pte_updates' | ||
| output = process.system_output(cmd, shell=True) | ||
| return(int(str(output).split()[1].strip('\''))) |
There was a problem hiding this comment.
@Pavithra1602 I think better to use [-1] and why strip(''')? we have only space character i feel
# cat /proc/vmstat | grep numa_pte_updates
numa_pte_updates 94736
There was a problem hiding this comment.
I am getting an extra ' if we are not using strip()
[stdout] b'numa_pte_updates 3978'
[stdout]
[stdout] 3978'
memory/autonuma.py
Outdated
| """ | ||
| cmd = 'cat /proc/vmstat | grep numa_hint_faults | head -1' | ||
| output = process.system_output(cmd, shell=True) | ||
| return(int(str(output).split()[1].strip('\''))) |
There was a problem hiding this comment.
same here, better use split()[-1]
There was a problem hiding this comment.
same here getting an extra ' if strip is not used.
There was a problem hiding this comment.
can you give a try if .decode() or .stdout_text can help here?
like below
output = process.run(cmd, ignore_status=True, sudo=True, shell=True).stdout_text
or
out = process.run(cmd, ignore_status=True, sudo=True, shell=True).decode()
memory/autonuma.py
Outdated
| if not smm.check_installed(packages) and not smm.install(packages): | ||
| self.cancel('%s is needed for the test to be run' % packages) | ||
|
|
||
| self.url = 'https://sourceforge.net/projects/ebizzy/files/ebizzy/0.3/ebizzy-0.3.tar.gz' |
There was a problem hiding this comment.
@Pavithra1602 can you please move this as yaml parameter?
memory/autonuma.py
Outdated
| This test case runs downloading, extracting, and running the autonuma-benchmark tests, | ||
| Test results need to be verified manually. | ||
| """ | ||
| url_autonuma = 'https://github.com/pholasek/autonuma-benchmark/archive/refs/heads/master.zip' |
There was a problem hiding this comment.
sure sending an updated patch
|
@Pavithra1602 please add the runs logs from all linux variants (RHEL, SLES15X, SLES16) |
…hint_faults v3 Test enables and disables numa_balancing by writing to /proc/sys/kernel/numa_balancing and verifies numa_pte_updates and numa_hint_faults Signed-off-by: Pavithra <pavrampu@linux.ibm.com>
|
SLES: ltcden10-lp12:/home/avocado-fvt-wrapper/tests/avocado-misc-tests/memory # avocado run --max-parallel-tasks=1 autonuma.py RHEL: avocado run --max-parallel-tasks=1 autonuma.py Fetching asset from autonuma.py:AutoNuma.test |
Naresh-ibm
left a comment
Naresh-ibm
left a comment
There was a problem hiding this comment.
@Pavithra1602 Thank for the PR
LGTM
2 participants
Test enables and disables numa_balancing by writing to /proc/sys/kernel/numa_balancing and verifies numa_pte_updates and numa_hint_faults