Skip to content

Check record flags before tape lookup in AReal hot paths - #214

Open
auto-differentiation-dev wants to merge 4 commits into
mainfrom
perf/passive-tape-check-reorder
Open

Check record flags before tape lookup in AReal hot paths#214
auto-differentiation-dev wants to merge 4 commits into
mainfrom
perf/passive-tape-check-reorder

Conversation

@auto-differentiation-dev

Copy link
Copy Markdown
Collaborator

Reorder checks so plain member reads gate the thread-local tape lookup, skipping the TLS access for passive variables. Recording behaviour is unchanged. Adds tests for the passive/recorded semantics of each path.

@boring-cyborg boring-cyborg Bot added benchmarks Run benchmark workflow src test labels Jun 12, 2026
@codacy-production

codacy-production Bot commented Jun 12, 2026

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics -2 complexity · 2 duplication

Metric Results
Complexity -2
Duplication 2

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

Reorder checks so plain member reads gate the thread-local tape lookup,
skipping the TLS access for passive variables. Recording behaviour is
unchanged. Adds tests for the passive/recorded semantics of each path.
@auto-differentiation-dev
auto-differentiation-dev force-pushed the perf/passive-tape-check-reorder branch from d02f65e to d3d27f9 Compare June 12, 2026 10:42
@github-actions

github-actions Bot commented Jun 12, 2026

Copy link
Copy Markdown

Test Results

    108 files   -     3      108 suites   - 3   5h 0m 43s ⏱️ - 23m 36s
  2 995 tests +    6    2 991 ✅ +    6    4 💤 ± 0  0 ❌ ±0 
212 186 runs   - 5 343  211 754 ✅  - 5 331  432 💤  - 12  0 ❌ ±0 

Results for commit d3d27f9. ± Comparison against base commit f0aa569.

♻️ This comment has been updated with latest results.

@coveralls

coveralls commented Jun 12, 2026

Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 27418896365

Coverage remained the same at 98.999%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: 18 of 18 lines across 1 file are fully covered (100%).
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 2897
Covered Lines: 2868
Line Coverage: 99.0%
Coverage Strength: 145808869.52 hits per line

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

benchmarks Run benchmark workflow src test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants